[ObjC ARC] Converts ios/chrome/browser:unit_tests to ARC.

ios/chrome/browser/installation_notifier_unittest.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/installation_notifier.h"
 
 #include <stdint.h>
 #import <UIKit/UIKit.h>
 
 #include "base/ios/block_types.h"
-#include "base/mac/scoped_nsobject.h"
 #include "base/message_loop/message_loop.h"
 #include "base/test/histogram_tester.h"
 #include "ios/web/public/test/test_web_thread.h"
 #include "net/base/backoff_entry.h"
 #include "testing/platform_test.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 @interface MockDispatcher : NSObject<DispatcherProtocol>
 - (int64_t)lastDelayInNSec;
 @end
 
 @implementation MockDispatcher {

[sdefresne, 2017/02/13 14:21:23]

This is not a mock, this is a fake :-(

[lody, 2017/02/13 15:40:10]

Done.

   int _dispatchCount;
   int64_t _lastDelayInNSec;
-  base::scoped_nsobject<NSMutableDictionary> _blocks;
+  NSMutableDictionary* _blocks;
 }
 
 - (instancetype)init {
   if ((self = [super init]))
-    _blocks.reset([[NSMutableDictionary alloc] init]);
+    _blocks = [[NSMutableDictionary alloc] init];
   return self;
 }
 
 #pragma mark -
 #pragma mark Testing methods
 
 - (void)executeAfter:(int)dispatchCount block:(ProceduralBlock)block {
-  [_blocks setObject:[[block copy] autorelease]
+  [_blocks setObject:[block copy]
               forKey:[NSNumber numberWithInt:dispatchCount]];
 }
 
 - (int64_t)lastDelayInNSec {
   return _lastDelayInNSec;
 }
 
 #pragma mark -
 #pragma mark DispatcherProtocol
 
@@ skipping 57 matching lines @@
 
 namespace {
 
 class InstallationNotifierTest : public PlatformTest {
  public:
   InstallationNotifierTest() : ui_thread_(web::WebThread::UI, &message_loop_) {}
 
  protected:
   void SetUp() override {
     installationNotifier_ = [InstallationNotifier sharedInstance];
-    dispatcher_ = [[MockDispatcher alloc] init];
-    notificationReceiver1_.reset(([[MockNotificationReceiver alloc] init]));
-    notificationReceiver2_.reset(([[MockNotificationReceiver alloc] init]));
-    sharedApplication_.reset([[MockUIApplication alloc] init]);
+    MockDispatcher* dispatcher = [[MockDispatcher alloc] init];
+    dispatcher_ = dispatcher;
+    notificationReceiver1_ = ([[MockNotificationReceiver alloc] init]);
+    notificationReceiver2_ = ([[MockNotificationReceiver alloc] init]);
+    sharedApplication_ = [[MockUIApplication alloc] init];
     [installationNotifier_ setSharedApplication:sharedApplication_];
     [installationNotifier_ setDispatcher:dispatcher_];
     histogramTester_.reset(new base::HistogramTester());
   }
 
   void VerifyHistogramValidity(int expectedYes, int expectedNo) {
     histogramTester_->ExpectTotalCount("NativeAppLauncher.InstallationDetected",
                                        expectedYes + expectedNo);
     histogramTester_->ExpectBucketCount(
         "NativeAppLauncher.InstallationDetected", YES, expectedYes);
     histogramTester_->ExpectBucketCount(
         "NativeAppLauncher.InstallationDetected", NO, expectedNo);
   }
 
   void VerifyDelay(int pollingIteration) {
     double delayInMSec = [dispatcher_ lastDelayInNSec] / NSEC_PER_MSEC;
     double initialDelayInMSec =
         [installationNotifier_ backOffPolicy]->initial_delay_ms;
     double multiplyFactor =
         [installationNotifier_ backOffPolicy]->multiply_factor;
     double expectedDelayInMSec =
         initialDelayInMSec * pow(multiplyFactor, pollingIteration);
     double jitter = [installationNotifier_ backOffPolicy]->jitter_factor;
     EXPECT_NEAR(delayInMSec, expectedDelayInMSec,
                 50 + jitter * expectedDelayInMSec);
   }
 
   base::MessageLoopForUI message_loop_;
   web::TestWebThread ui_thread_;
-  __unsafe_unretained InstallationNotifier*
-      installationNotifier_;  // Weak pointer to singleton.
-  __unsafe_unretained MockDispatcher*
-      dispatcher_;  // Weak. installationNotifier_ owns it.
-  base::scoped_nsobject<MockNotificationReceiver> notificationReceiver1_;
-  base::scoped_nsobject<MockNotificationReceiver> notificationReceiver2_;
-  base::scoped_nsobject<MockUIApplication> sharedApplication_;
+  __weak InstallationNotifier*
+      installationNotifier_;           // Weak pointer to singleton.

[sdefresne, 2017/02/13 14:21:23]

You can probably remove those comments now (since the code uses __weak).

[lody, 2017/02/13 15:40:10]

Done.

+  __weak MockDispatcher* dispatcher_;  // Weak. installationNotifier_ owns it.
+  MockNotificationReceiver* notificationReceiver1_;
+  MockNotificationReceiver* notificationReceiver2_;
+  MockUIApplication* sharedApplication_;
   std::unique_ptr<base::HistogramTester> histogramTester_;
 };
 
 TEST_F(InstallationNotifierTest, RegisterWithAppAlreadyInstalled) {
   [sharedApplication_ setCanOpenURL:YES];
   [installationNotifier_
       registerForInstallationNotifications:notificationReceiver1_
                               withSelector:@selector(receivedNotification)
                                  forScheme:@"foo-scheme"];
   EXPECT_EQ(1, [notificationReceiver1_ notificationCount]);
@@ skipping 107 matching lines @@
 
 TEST_F(InstallationNotifierTest, TestThatEmptySchemeDoesntCrashChrome) {
   [installationNotifier_
       registerForInstallationNotifications:notificationReceiver1_
                               withSelector:@selector(receivedNotification)
                                  forScheme:nil];
   [installationNotifier_ unregisterForNotifications:notificationReceiver1_];
 }
 
 }  // namespace