Increase presubmit lint pickiness on vr_shell code

Increase presubmit lint pickiness on vr_shell code

Chrome's default lint checks are lax, to accomodate a large codebase.
Set a higher bar within vr_shell, while we can.  Making this change will
necessitate sporadic future lint fixes, as people edit affected files.
At this stage, it's not more than a few per file.

BUG=None

Review-Url: https://codereview.chromium.org/2684163003
Cr-Commit-Position: refs/heads/master@{#449391}
Committed: https://chromium.googlesource.com/chromium/src/+/76115ff06c69c188db4f51db7816cb5700d63788

[cjgrant, 2017-02-09 15:35:15]

cjgrant@chromium.org changed reviewers:
+ asimjour@chromium.org, bajones@chromium.org, bshe@chromium.org,
mthiesse@chromium.org, tiborg@chromium.org

[cjgrant, 2017-02-09 15:35:15]

Folks, please voice any objections to this if you have them.

[cjgrant, 2017-02-09 15:38:28]

For reference, here's what we'll expose with the proposed verbosity level:

animation.cc:20:  Add #include <utility> for move  [build/include_what_you_use]
[4]                                 
non_presenting_gvr_delegate.cc:14:  Use int16/int64/etc, rather than the C type
long  [runtime/int] [4]             
non_presenting_gvr_delegate.cc:120:  Use int16/int64/etc, rather than the C type
long  [runtime/int] [4]            
non_presenting_gvr_delegate.cc:31:  Add #include <utility> for move 
[build/include_what_you_use] [4]               
non_presenting_gvr_delegate.h:35:  Use int16/int64/etc, rather than the C type
long  [runtime/int] [4]              
non_presenting_gvr_delegate.h:56:  Add #include <memory> for unique_ptr<> 
[build/include_what_you_use] [4]         
ui_elements.cc:140:  Using C-style cast.  Use static_cast<double>(...) instead 
[readability/casting] [4]           
ui_elements.cc:22:  Add #include <limits> for numeric_limits<> 
[build/include_what_you_use] [4]                    
ui_elements_unittest.cc:153:  Add #include <utility> for move 
[build/include_what_you_use] [4]                     
ui_interface.cc:90:  Add #include <string> for string 
[build/include_what_you_use] [4]                             
ui_interface.h:46:  Add #include <string> for string 
[build/include_what_you_use] [4]                              
ui_scene.cc:297:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                               
ui_scene.cc:305:  Add #include <utility> for move  [build/include_what_you_use]
[4]                                 
ui_scene.cc:107:  Add #include <string> for string  [build/include_what_you_use]
[4]                                
ui_scene_unittest.cc:435:  Add #include <utility> for move 
[build/include_what_you_use] [4]                        
vr_controller.cc:229:  Add #include <utility> for move 
[build/include_what_you_use] [4]                            
vr_controller.cc:45:  Add #include <algorithm> for min 
[build/include_what_you_use] [4]                            
vr_gl_thread.cc:35:  Add #include <utility> for move 
[build/include_what_you_use] [4]                              
vr_gl_util.cc:74:  Add #include <string> for string 
[build/include_what_you_use] [4]                               
vr_gl_util.h:30:  Add #include <string> for string  [build/include_what_you_use]
[4]                                
vr_input_manager.cc:39:  Add #include <memory> for unique_ptr<> 
[build/include_what_you_use] [4]                   
vr_input_manager.h:26:  Add #include <memory> for unique_ptr<> 
[build/include_what_you_use] [4]                    
vr_math.cc:26:  Using C-style cast.  Use reinterpret_cast<float*>(...) instead 
[readability/casting] [4]           
vr_shell.cc:482:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                               
vr_shell_delegate.cc:34:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                       
vr_shell_delegate.cc:171:  Add #include <utility> for move 
[build/include_what_you_use] [4]                        
vr_shell_delegate.h:66:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                        
vr_shell_delegate.h:61:  Add #include <memory> for unique_ptr<> 
[build/include_what_you_use] [4]                   
vr_shell_gl.cc:37:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                             
vr_shell_gl.cc:311:  Using C-style cast.  Use static_cast<int>(...) instead 
[readability/casting] [4]              
vr_shell_gl.cc:312:  Using C-style cast.  Use static_cast<int>(...) instead 
[readability/casting] [4]              
vr_shell_gl.cc:313:  Using C-style cast.  Use static_cast<int>(...) instead 
[readability/casting] [4]              
vr_shell_gl.cc:1037:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                           
vr_shell_gl.cc:641:  Add #include <limits> for numeric_limits<> 
[build/include_what_you_use] [4]                   
vr_shell_gl.cc:799:  Add #include <vector> for vector<> 
[build/include_what_you_use] [4]                           
vr_shell_gl.h:88:  Use int16/int64/etc, rather than the C type long 
[runtime/int] [4]                              
vr_shell_gl.h:153:  Add #include <utility> for pair<> 
[build/include_what_you_use] [4]                             
vr_shell_gl.h:174:  Add #include <vector> for vector<> 
[build/include_what_you_use] [4]                            
vr_shell.h:176:  Use int16/int64/etc, rather than the C type long  [runtime/int]
[4]                                
vr_shell_renderer.cc:303:  Using C-style cast.  Use
reinterpret_cast<float*>(...) instead  [readability/casting] [4]
vr_shell_renderer.cc:524:  Using C-style cast.  Use
reinterpret_cast<float*>(...) instead  [readability/casting] [4]
vr_usage_monitor.cc:5:  Include the directory when naming .h files 
[build/include] [4]                             
Total errors found: 42

[mthiesse, 2017-02-09 15:40:42]

lgtm

[tiborg, 2017-02-09 15:42:45]

lgtm

[tiborg, 2017-02-09 15:43:30]

This will help a lot! In the future we should also turn on the linter for
non-c++ files such as JS.

[bshe, 2017-02-09 15:55:50]

LGTM

https://codereview.chromium.org/2684163003/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/PRESUBMIT.py (right):

https://codereview.chromium.org/2684163003/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/PRESUBMIT.py:29: x,
white_list=INCLUDE_CPP_FILES_ONLY)
lnit: should this be four spaces? :)

[bajones, 2017-02-09 18:02:53]

lgtm! Being more disciplined now will be FAR less painful than trying to switch
this on in the future.

[asimjour, 2017-02-09 19:35:01]

On 2017/02/09 18:02:53, bajones wrote:
> lgtm! Being more disciplined now will be FAR less painful than trying to
switch
> this on in the future.

lgtm

[cjgrant, 2017-02-09 19:52:52]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-02-09 19:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
bajones@chromium.org, asimjour@google.com, mthiesse@chromium.org,
tiborg@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2684163003/#ps40001
(title: "Fix nit.")

[commit-bot: I haz the power, 2017-02-09 19:53:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[girard, 2017-02-09 20:05:31]

On 2017/02/09 19:53:45, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm;)

[commit-bot: I haz the power, 2017-02-09 20:23:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486669972204500,
"parent_rev": "6d7338d05ae5eb0503c83dc08f66afb5647eb680", "commit_rev":
"76115ff06c69c188db4f51db7816cb5700d63788"}

[commit-bot: I haz the power, 2017-02-09 20:24:06]

Description was changed from

==========
Increase presubmit lint pickiness on vr_shell code

Chrome's default lint checks are lax, to accomodate a large codebase.
Set a higher bar within vr_shell, while we can.  Making this change will
necessitate sporadic future lint fixes, as people edit affected files.
At this stage, it's not more than a few per file.

BUG=None
==========

to

==========
Increase presubmit lint pickiness on vr_shell code

Chrome's default lint checks are lax, to accomodate a large codebase.
Set a higher bar within vr_shell, while we can.  Making this change will
necessitate sporadic future lint fixes, as people edit affected files.
At this stage, it's not more than a few per file.

BUG=None

Review-Url: https://codereview.chromium.org/2684163003
Cr-Commit-Position: refs/heads/master@{#449391}
Committed:
https://chromium.googlesource.com/chromium/src/+/76115ff06c69c188db4f51db7816...
==========

[commit-bot: I haz the power, 2017-02-09 20:24:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/76115ff06c69c188db4f51db7816...