Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3865)

Unified Diff: chrome/browser/android/vr_shell/PRESUBMIT.py

Issue 2684163003: Increase presubmit lint pickiness on vr_shell code (Closed)
Patch Set: Fix nit. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/PRESUBMIT.py
diff --git a/chrome/browser/android/vr_shell/PRESUBMIT.py b/chrome/browser/android/vr_shell/PRESUBMIT.py
new file mode 100644
index 0000000000000000000000000000000000000000..2292c80e5bf4cdc2409967ab2c5942d8d9cfe6ad
--- /dev/null
+++ b/chrome/browser/android/vr_shell/PRESUBMIT.py
@@ -0,0 +1,41 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for changes affecting chrome/browser/android/vr_shell
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into depot_tools.
+"""
+
+import re
+
+# chrome/PRESUBMIT.py blocks several linters due to the infeasibility of
+# enforcing them on a large codebase. Here we'll start by enforcing all
+# linters, and add exclusions if necessary.
+#
+# Note that this list must be non-empty, or cpplint will use its default set of
+# filters. Therefore, explicitly enable a single dummy linter.
+LINT_FILTERS = [
+ '+build/include',
+]
+
+VERBOSITY_LEVEL = 4
+
+INCLUDE_CPP_FILES_ONLY = (r'.*\.(cc|h)$',)
+
+def _CheckChangeLintsClean(input_api, output_api):
+ sources = lambda x: input_api.FilterSourceFile(
+ x, white_list=INCLUDE_CPP_FILES_ONLY)
+ return input_api.canned_checks.CheckChangeLintsClean(
+ input_api, output_api, sources, LINT_FILTERS, VERBOSITY_LEVEL)
+
+def CheckChangeOnUpload(input_api, output_api):
+ results = []
+ results.extend(_CheckChangeLintsClean(input_api, output_api))
+ return results
+
+def CheckChangeOnCommit(input_api, output_api):
+ results = []
+ results.extend(_CheckChangeLintsClean(input_api, output_api))
+ return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698