Make TestJSArrayForAllocationMemento less awkward.

Make TestJSArrayForAllocationMemento less awkward.

Generated code ended up having two conditional jump statements in a
row. Also introduce JumpIfJSArrayHasAllocationMemento which handles
most cases more simply.

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17220

[mvstanton, 2013-10-15 12:38:56]

Hi Jakob, PTAL. If the approach is solid, I'll upload the ports. thx,
--Michael

[Jakob Kummerow, 2013-10-15 12:51:55]

Looks good, go ahead with the ports. Thanks for doing this!

[mvstanton, 2013-10-15 13:45:17]

Okay, ports present.
--Michael

[Jakob Kummerow, 2013-10-15 13:56:27]

LGTM with nits.

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
src/arm/macro-assembler-arm.cc:3862: Label *no_memento_found) {
nit: "Label* no_memento_found" (swap * and the space)

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
src/arm/macro-assembler-arm.h:1391: // If allocation info is present, condition
flags are set to equal
nit: s/equal/eq./ 
Since the enum value is called "eq" on ARM, let's keep exactly that term in the
comment (but with a trailing full stop).

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.cc:4925: Label *no_memento_found) {
nit: s/ */* /

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.h:1415: // If allocation info is present, condition
flags are set to equal
nit: trailing full stop

[mvstanton, 2013-10-15 15:04:16]

Thanks very much!
--Michael

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
src/arm/macro-assembler-arm.cc:3862: Label *no_memento_found) {
On 2013/10/15 13:56:27, Jakob wrote:
> nit: "Label* no_memento_found" (swap * and the space)

Done.

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-arm.h
File src/arm/macro-assembler-arm.h (right):

https://codereview.chromium.org/26841009/diff/7001/src/arm/macro-assembler-ar...
src/arm/macro-assembler-arm.h:1391: // If allocation info is present, condition
flags are set to equal
On 2013/10/15 13:56:27, Jakob wrote:
> nit: s/equal/eq./ 
> Since the enum value is called "eq" on ARM, let's keep exactly that term in
the
> comment (but with a trailing full stop).

Done.

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.cc:4925: Label *no_memento_found) {
On 2013/10/15 13:56:27, Jakob wrote:
> nit: s/ */* /

Done.

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):

https://codereview.chromium.org/26841009/diff/7001/src/x64/macro-assembler-x6...
src/x64/macro-assembler-x64.h:1415: // If allocation info is present, condition
flags are set to equal
On 2013/10/15 13:56:27, Jakob wrote:
> nit: trailing full stop

Done.

[mvstanton, 2013-10-15 15:04:42]

Committed patchset #3 manually as r17220 (presubmit successful).