Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 26841009: Make TestJSArrayForAllocationMemento less awkward. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments addressed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3494 matching lines...) Expand 10 before | Expand all | Expand 10 after
3505 j(not_equal, call_runtime); 3505 j(not_equal, call_runtime);
3506 3506
3507 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset)); 3507 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset));
3508 cmp(ecx, isolate()->factory()->null_value()); 3508 cmp(ecx, isolate()->factory()->null_value());
3509 j(not_equal, &next); 3509 j(not_equal, &next);
3510 } 3510 }
3511 3511
3512 3512
3513 void MacroAssembler::TestJSArrayForAllocationMemento( 3513 void MacroAssembler::TestJSArrayForAllocationMemento(
3514 Register receiver_reg, 3514 Register receiver_reg,
3515 Register scratch_reg) { 3515 Register scratch_reg,
3516 Label no_memento_available; 3516 Label* no_memento_found) {
3517
3518 ExternalReference new_space_start = 3517 ExternalReference new_space_start =
3519 ExternalReference::new_space_start(isolate()); 3518 ExternalReference::new_space_start(isolate());
3520 ExternalReference new_space_allocation_top = 3519 ExternalReference new_space_allocation_top =
3521 ExternalReference::new_space_allocation_top_address(isolate()); 3520 ExternalReference::new_space_allocation_top_address(isolate());
3522 3521
3523 lea(scratch_reg, Operand(receiver_reg, 3522 lea(scratch_reg, Operand(receiver_reg,
3524 JSArray::kSize + AllocationMemento::kSize - kHeapObjectTag)); 3523 JSArray::kSize + AllocationMemento::kSize - kHeapObjectTag));
3525 cmp(scratch_reg, Immediate(new_space_start)); 3524 cmp(scratch_reg, Immediate(new_space_start));
3526 j(less, &no_memento_available); 3525 j(less, no_memento_found);
3527 cmp(scratch_reg, Operand::StaticVariable(new_space_allocation_top)); 3526 cmp(scratch_reg, Operand::StaticVariable(new_space_allocation_top));
3528 j(greater, &no_memento_available); 3527 j(greater, no_memento_found);
3529 cmp(MemOperand(scratch_reg, -AllocationMemento::kSize), 3528 cmp(MemOperand(scratch_reg, -AllocationMemento::kSize),
3530 Immediate(isolate()->factory()->allocation_memento_map())); 3529 Immediate(isolate()->factory()->allocation_memento_map()));
3531 bind(&no_memento_available);
3532 } 3530 }
3533 3531
3534 3532
3535 } } // namespace v8::internal 3533 } } // namespace v8::internal
3536 3534
3537 #endif // V8_TARGET_ARCH_IA32 3535 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698