Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 26841009: Make TestJSArrayForAllocationMemento less awkward. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments addressed. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3840 matching lines...) Expand 10 before | Expand all | Expand 10 after
3851 b(ne, call_runtime); 3851 b(ne, call_runtime);
3852 3852
3853 ldr(r2, FieldMemOperand(r1, Map::kPrototypeOffset)); 3853 ldr(r2, FieldMemOperand(r1, Map::kPrototypeOffset));
3854 cmp(r2, null_value); 3854 cmp(r2, null_value);
3855 b(ne, &next); 3855 b(ne, &next);
3856 } 3856 }
3857 3857
3858 3858
3859 void MacroAssembler::TestJSArrayForAllocationMemento( 3859 void MacroAssembler::TestJSArrayForAllocationMemento(
3860 Register receiver_reg, 3860 Register receiver_reg,
3861 Register scratch_reg) { 3861 Register scratch_reg,
3862 Label no_memento_available; 3862 Label* no_memento_found) {
3863 ExternalReference new_space_start = 3863 ExternalReference new_space_start =
3864 ExternalReference::new_space_start(isolate()); 3864 ExternalReference::new_space_start(isolate());
3865 ExternalReference new_space_allocation_top = 3865 ExternalReference new_space_allocation_top =
3866 ExternalReference::new_space_allocation_top_address(isolate()); 3866 ExternalReference::new_space_allocation_top_address(isolate());
3867 add(scratch_reg, receiver_reg, 3867 add(scratch_reg, receiver_reg,
3868 Operand(JSArray::kSize + AllocationMemento::kSize - kHeapObjectTag)); 3868 Operand(JSArray::kSize + AllocationMemento::kSize - kHeapObjectTag));
3869 cmp(scratch_reg, Operand(new_space_start)); 3869 cmp(scratch_reg, Operand(new_space_start));
3870 b(lt, &no_memento_available); 3870 b(lt, no_memento_found);
3871 mov(ip, Operand(new_space_allocation_top)); 3871 mov(ip, Operand(new_space_allocation_top));
3872 ldr(ip, MemOperand(ip)); 3872 ldr(ip, MemOperand(ip));
3873 cmp(scratch_reg, ip); 3873 cmp(scratch_reg, ip);
3874 b(gt, &no_memento_available); 3874 b(gt, no_memento_found);
3875 ldr(scratch_reg, MemOperand(scratch_reg, -AllocationMemento::kSize)); 3875 ldr(scratch_reg, MemOperand(scratch_reg, -AllocationMemento::kSize));
3876 cmp(scratch_reg, 3876 cmp(scratch_reg,
3877 Operand(isolate()->factory()->allocation_memento_map())); 3877 Operand(isolate()->factory()->allocation_memento_map()));
3878 bind(&no_memento_available);
3879 } 3878 }
3880 3879
3881 3880
3882 Register GetRegisterThatIsNotOneOf(Register reg1, 3881 Register GetRegisterThatIsNotOneOf(Register reg1,
3883 Register reg2, 3882 Register reg2,
3884 Register reg3, 3883 Register reg3,
3885 Register reg4, 3884 Register reg4,
3886 Register reg5, 3885 Register reg5,
3887 Register reg6) { 3886 Register reg6) {
3888 RegList regs = 0; 3887 RegList regs = 0;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
3966 void CodePatcher::EmitCondition(Condition cond) { 3965 void CodePatcher::EmitCondition(Condition cond) {
3967 Instr instr = Assembler::instr_at(masm_.pc_); 3966 Instr instr = Assembler::instr_at(masm_.pc_);
3968 instr = (instr & ~kCondMask) | cond; 3967 instr = (instr & ~kCondMask) | cond;
3969 masm_.emit(instr); 3968 masm_.emit(instr);
3970 } 3969 }
3971 3970
3972 3971
3973 } } // namespace v8::internal 3972 } } // namespace v8::internal
3974 3973
3975 #endif // V8_TARGET_ARCH_ARM 3974 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/ia32/codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698