Issue 2684073004: [css-flexbox] Clear override sizes when we're no longer a flex item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2684073004: [css-flexbox] Clear override sizes when we're no longer a flex item (Closed)

Created:
3 years, 10 months ago by cbiesinger

Modified:
3 years, 10 months ago

Reviewers:
eae

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[css-flexbox] Clear override sizes when we're no longer a flex item When we change to being absolutely positioned, we need to clear the override size so as to avoid being affected by it. R=eae@chromium.org BUG=687747, 688938, 688253 Review-Url: https://codereview.chromium.org/2684463002 Cr-Commit-Position: refs/heads/master@{#448709} (cherry picked from commit 3c12965b9c068f00290a4c4ecce1cc9d404ec20a) Review-Url: https://codereview.chromium.org/2684073004 . Cr-Commit-Position: refs/branch-heads/2987@{#395} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/986dbbcbd724c5fb503b26ca44bec5b68dc3a88a

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -0 lines)			Patch
	A	third_party/WebKit/LayoutTests/css3/flexbox/change-flexitem-into-abspos.html	View		1 chunk	+39 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutBox.cpp	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

cbiesinger

3 years, 10 months ago (2017-02-08 21:15:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
986dbbcbd724c5fb503b26ca44bec5b68dc3a88a.