Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2684463002: [css-flexbox] Clear override sizes when we're no longer a flex item (Closed)

Created:
3 years, 10 months ago by cbiesinger
Modified:
3 years, 10 months ago
Reviewers:
eae, cbiesinger1
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Clear override sizes when we're no longer a flex item When we change to being absolutely positioned, we need to clear the override size so as to avoid being affected by it. R=eae@chromium.org BUG=687747, 688938, 688253 Review-Url: https://codereview.chromium.org/2684463002 Cr-Commit-Position: refs/heads/master@{#448709} Committed: https://chromium.googlesource.com/chromium/src/+/3c12965b9c068f00290a4c4ecce1cc9d404ec20a

Patch Set 1 #

Patch Set 2 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/change-flexitem-into-abspos.html View 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
cbiesinger
3 years, 10 months ago (2017-02-07 00:36:50 UTC) #1
eae
LGTM
3 years, 10 months ago (2017-02-07 19:55:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684463002/20001
3 years, 10 months ago (2017-02-07 19:56:49 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:05:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3c12965b9c068f00290a4c4ecce1...

Powered by Google App Engine
This is Rietveld 408576698