Issue 2684033011: [Merge] [Password Manager] Fix sending votes for password generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2684033011: [Merge] [Password Manager] Fix sending votes for password generation. (Closed)

Created:
3 years, 10 months ago by dvadym

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[Merge] [Password Manager] Fix sending votes for password generation. Changes on CL https://codereview.chromium.org/2637823002/ made that fields with empty name/id disappeared from uploads. This CL fixes it. BUG=689999 Review-Url: https://codereview.chromium.org/2687683002 Cr-Commit-Position: refs/heads/master@{#449003} (cherry picked from commit 17c2759535e8a90b3bda092dcd4207ce554ee263) Review-Url: https://codereview.chromium.org/2684033011 . Cr-Commit-Position: refs/branch-heads/2987@{#434} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/74a6c5fae2ae05bd712fabc362d81d9f81a67e95

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	components/password_manager/core/browser/password_form_manager.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
	M	components/password_manager/core/browser/password_form_manager_unittest.cc	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

dvadym

3 years, 10 months ago (2017-02-10 13:54:54 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
74a6c5fae2ae05bd712fabc362d81d9f81a67e95.