[Password Manager] Fix sending votes for password generation.

[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with empty name/id disappeared from uploads. This CL fixes it.

BUG=689999
Review-Url: https://codereview.chromium.org/2687683002
Cr-Commit-Position: refs/heads/master@{#449003}
Committed: https://chromium.googlesource.com/chromium/src/+/17c2759535e8a90b3bda092dcd4207ce554ee263

[dvadym, 2017-02-08 14:36:51]

Description was changed from

==========
Fix sending votes for password generation.

BUG=None
==========

to

==========
[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with
empty name/id disappeared from uploads. This CL fixes it.

BUG=None
==========

[dvadym, 2017-02-08 14:36:51]

dvadym@chromium.org changed reviewers:
+ kolos@chromium.org

[dvadym, 2017-02-08 14:38:48]

Hi Maxim,

 could you please review this CL?

Regards,
Vadym

https://codereview.chromium.org/2687683002/diff/1/components/password_manager...
File components/password_manager/core/browser/password_form_manager_unittest.cc
(right):

https://codereview.chromium.org/2687683002/diff/1/components/password_manager...
components/password_manager/core/browser/password_form_manager_unittest.cc:2808:
StartUploadRequest(_, false, _, _, true));
This is not directly related to this CL. This method is called, but it's not
expected, so there is a warning in output on test run that's just a clutter.

[dvadym, 2017-02-08 14:42:09]

Description was changed from

==========
[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with
empty name/id disappeared from uploads. This CL fixes it.

BUG=None
==========

to

==========
[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with
empty name/id disappeared from uploads. This CL fixes it.

BUG=689999
==========

[kolos1, 2017-02-08 15:10:35]

On 2017/02/08 14:38:48, dvadym wrote:
> Hi Maxim,
> 
>  could you please review this CL?
> 
> Regards,
> Vadym
> 
>
https://codereview.chromium.org/2687683002/diff/1/components/password_manager...
> File
components/password_manager/core/browser/password_form_manager_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/2687683002/diff/1/components/password_manager...
>
components/password_manager/core/browser/password_form_manager_unittest.cc:2808:
> StartUploadRequest(_, false, _, _, true));
> This is not directly related to this CL. This method is called, but it's not
> expected, so there is a warning in output on test run that's just a clutter.

LGTM

[dvadym, 2017-02-08 15:10:52]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2017-02-08 15:11:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:03:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486566652079160, "parent_rev":
"5a45dad7fdb43321d7784461480c2fff5e0dd252", "commit_rev":
"17c2759535e8a90b3bda092dcd4207ce554ee263"}

[commit-bot: I haz the power, 2017-02-08 16:04:33]

Description was changed from

==========
[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with
empty name/id disappeared from uploads. This CL fixes it.

BUG=689999
==========

to

==========
[Password Manager] Fix sending votes for password generation.

Changes on CL https://codereview.chromium.org/2637823002/ made that fields with
empty name/id disappeared from uploads. This CL fixes it.

BUG=689999

Review-Url: https://codereview.chromium.org/2687683002
Cr-Commit-Position: refs/heads/master@{#449003}
Committed:
https://chromium.googlesource.com/chromium/src/+/17c2759535e8a90b3bda092dcd42...
==========

[commit-bot: I haz the power, 2017-02-08 16:04:36]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17c2759535e8a90b3bda092dcd42...