Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tools/perf/benchmarks/media.py

Issue 2684033009: Re-enable media.android.tough_video_cases. (Closed)
Patch Set: Fixed so it only runs on Android. Thanks johnchen@! Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index 5c6faf387b34118e31bcbc552e5fdb0f86c0b7d8..02ae46dfdbde335d2103d33ee5fae351512c94bc 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -74,7 +74,7 @@ class MediaNetworkSimulation(perf_benchmark.PerfBenchmark):
return 'media.media_cns_cases'
-@benchmark.Disabled('android') # crbug.com/671628, WebView: crbug.com/419689.
+@benchmark.Disabled('l', 'android-webview') # WebView: crbug.com/419689.
class MediaAndroid(perf_benchmark.PerfBenchmark):
"""Obtains media metrics for key user scenarios on Android."""
test = media.Media
@@ -85,18 +85,9 @@ class MediaAndroid(perf_benchmark.PerfBenchmark):
@classmethod
def ShouldDisable(cls, possible_browser):
- # crbug.com/672059
if possible_browser.platform.GetOSName() != "android":
return True
- # crbug.com/448092
- if cls.IsSvelte(possible_browser):
- return True
-
- # crbug.com/647372
- if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X':
- return True
-
- return False
+ return cls.IsSvelte(possible_browser)
@classmethod
def Name(cls):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698