[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotation to ExecuteJavascript function in order to handle not-yet-ARC files.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684023003
Cr-Commit-Position: refs/heads/master@{#449278}
Committed: https://chromium.googlesource.com/chromium/src/+/ae94774be25333de017df83c67e674b6ac3dbe4b

[lody, 2017-02-08 16:13:20]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 16:13:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:19:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 16:19:49]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lody, 2017-02-09 10:26:55]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 10:27:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 11:32:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 11:32:18]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-09 12:59:26]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotation to ExecuteJavascript function in order to
handle not-yet-ARC files.
BUG=624363
TEST=None
==========

[lody, 2017-02-09 13:01:23]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-09 13:01:24]

Please review. This is where I made that __unsafe_unretained changed as
suggested.

[sdefresne, 2017-02-09 13:12:18]

lgtm

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_earl_grey.h (right):

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_earl_grey.h:22: id ExecuteJavaScript(NSString*
javascript,
I think we'll need to keep the __unsafe_unretained even when all callers are
converted to ARC. I'm not sure, but I think there is no automatic retain
semantic for pointer to pointer in Objective-C and you always need an explicit
annotation with ARC in that case (it may be changed to __autoreleasing then
though).

[lody, 2017-02-09 13:25:45]

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_earl_grey.h (right):

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_earl_grey.h:22: id ExecuteJavaScript(NSString*
javascript,
On 2017/02/09 13:12:17, sdefresne wrote:
> I think we'll need to keep the __unsafe_unretained even when all callers are
> converted to ARC. I'm not sure, but I think there is no automatic retain
> semantic for pointer to pointer in Objective-C and you always need an explicit
> annotation with ARC in that case (it may be changed to __autoreleasing then
> though).

It actually seems (
https://clang.llvm.org/docs/AutomaticReferenceCounting.html#template-arguments )
that __autoreleasing is the default in this case, so should be removeable.

[lody, 2017-02-09 13:25:51]

The CQ bit was checked by lod@chromium.org

[commit-bot: I haz the power, 2017-02-09 13:26:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 13:29:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486646751488590,
"parent_rev": "c6abc2378d27fb64de389472c5af3ac74305ea51", "commit_rev":
"ae94774be25333de017df83c67e674b6ac3dbe4b"}

[commit-bot: I haz the power, 2017-02-09 13:30:27]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotation to ExecuteJavascript function in order to
handle not-yet-ARC files.
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:
Added __unsafe_unretained annotation to ExecuteJavascript function in order to
handle not-yet-ARC files.
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684023003
Cr-Commit-Position: refs/heads/master@{#449278}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae94774be25333de017df83c67e6...
==========

[commit-bot: I haz the power, 2017-02-09 13:30:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ae94774be25333de017df83c67e6...

[sdefresne, 2017-02-09 13:49:23]

lgtm

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
File ios/chrome/test/earl_grey/chrome_earl_grey.h (right):

https://codereview.chromium.org/2684023003/diff/20001/ios/chrome/test/earl_gr...
ios/chrome/test/earl_grey/chrome_earl_grey.h:22: id ExecuteJavaScript(NSString*
javascript,
On 2017/02/09 13:25:44, lody wrote:
> On 2017/02/09 13:12:17, sdefresne wrote:
> > I think we'll need to keep the __unsafe_unretained even when all callers are
> > converted to ARC. I'm not sure, but I think there is no automatic retain
> > semantic for pointer to pointer in Objective-C and you always need an
explicit
> > annotation with ARC in that case (it may be changed to __autoreleasing then
> > though).
> 
> It actually seems (
> https://clang.llvm.org/docs/AutomaticReferenceCounting.html#template-arguments
)
> that __autoreleasing is the default in this case, so should be removeable.

Thank you for the pointer (though I think you meant to link to
https://clang.llvm.org/docs/AutomaticReferenceCounting.html#indirect-parameters).
Good to know.