Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: ios/chrome/test/earl_grey/chrome_earl_grey.h

Issue 2684023003: [ObjC ARC] Converts ios/chrome/test/earl_grey:test_support to ARC. (Closed)
Patch Set: Add __unsafe_unretained Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/test/earl_grey/chrome_assertions.mm ('k') | ios/chrome/test/earl_grey/chrome_earl_grey.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/test/earl_grey/chrome_earl_grey.h
diff --git a/ios/chrome/test/earl_grey/chrome_earl_grey.h b/ios/chrome/test/earl_grey/chrome_earl_grey.h
index f9ac0224b624cdb2a4b96fbe157b217a2942af9f..fdacda6a3c82f946abf28075e151b62ef11997fa 100644
--- a/ios/chrome/test/earl_grey/chrome_earl_grey.h
+++ b/ios/chrome/test/earl_grey/chrome_earl_grey.h
@@ -17,7 +17,10 @@ namespace chrome_test_util {
// error resulting from the execution, if one occurs. The return value is the
// result of the JavaScript execution. If the request is timed out, then nil is
// returned.
-id ExecuteJavaScript(NSString* javascript, NSError** out_error);
+// TODO(crbug.com/690057): Remove __unsafe_unretained once all callers are
+// converted to ARC.
+id ExecuteJavaScript(NSString* javascript,
sdefresne 2017/02/09 13:12:17 I think we'll need to keep the __unsafe_unretained
lody 2017/02/09 13:25:44 It actually seems ( https://clang.llvm.org/docs/Au
sdefresne 2017/02/09 13:49:23 Thank you for the pointer (though I think you mean
+ NSError* __unsafe_unretained* out_error);
} // namespace chrome_test_util
« no previous file with comments | « ios/chrome/test/earl_grey/chrome_assertions.mm ('k') | ios/chrome/test/earl_grey/chrome_earl_grey.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698