Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2683993003: Move toEventTarget to EventTarget (Closed)

Created:
3 years, 10 months ago by adithyas
Modified:
3 years, 10 months ago
Reviewers:
haraken, jbroman, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move toEventTarget to EventTarget For WrapperTypeInfo to move to platform/, it cannot have dependencies to core. This patch removes a dependency to EventTarget. BUG=682322 Review-Url: https://codereview.chromium.org/2683993003 Cr-Commit-Position: refs/heads/master@{#449820} Committed: https://chromium.googlesource.com/chromium/src/+/1d105d421b8d7468036f5777d8b7c9de45ce7463

Patch Set 1 #

Patch Set 2 : Format, remove header #

Total comments: 5

Patch Set 3 : Inline toEventTarget in V8Binding::toEventTarget #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -32 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 2 1 chunk +1 line, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp View 1 2 chunks +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (14 generated)
adithyas
3 years, 10 months ago (2017-02-10 15:23:57 UTC) #7
jbroman
https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp File third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp (right): https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp#newcode239 third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp:239: value = nullptr; The rest of this method can ...
3 years, 10 months ago (2017-02-10 16:03:16 UTC) #8
jbroman
https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp#newcode799 third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:799: return static_cast<EventTarget*>(window); nit: While you're here, you could remove ...
3 years, 10 months ago (2017-02-10 16:04:27 UTC) #9
jbroman
https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp#newcode799 third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:799: return static_cast<EventTarget*>(window); nit: While you're here, you could remove ...
3 years, 10 months ago (2017-02-10 16:04:28 UTC) #10
adithyas
https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp File third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp (right): https://codereview.chromium.org/2683993003/diff/20001/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp#newcode799 third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp:799: return static_cast<EventTarget*>(window); On 2017/02/10 at 16:04:27, jbroman wrote: > ...
3 years, 10 months ago (2017-02-10 18:39:49 UTC) #11
jbroman
lgtm
3 years, 10 months ago (2017-02-10 19:44:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683993003/40001
3 years, 10 months ago (2017-02-11 01:29:17 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1d105d421b8d7468036f5777d8b7c9de45ce7463
3 years, 10 months ago (2017-02-11 01:35:43 UTC) #21
jbroman
On 2017/02/11 at 01:35:43, commit-bot wrote: > Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1d105d421b8d7468036f5777d8b7c9de45ce7463 Err, I ...
3 years, 10 months ago (2017-02-11 02:23:15 UTC) #22
haraken
LGTM
3 years, 10 months ago (2017-02-11 09:42:19 UTC) #23
Yuki
3 years, 10 months ago (2017-02-13 05:44:20 UTC) #25
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698