Move toEventTarget to EventTarget

third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 778 matching lines @@
   // We return 0 here because |context| is detached from the Frame. If we
   // did return |frame| we could get in trouble because the frame could be
   // navigated to another security origin.
   return nullptr;
 }
 
 EventTarget* toEventTarget(v8::Isolate* isolate, v8::Local<v8::Value> value) {
   // We need to handle a DOMWindow specially, because a DOMWindow wrapper
   // exists on a prototype chain of v8Value.
   if (DOMWindow* window = toDOMWindow(isolate, value))
     return static_cast<EventTarget*>(window);

[jbroman, 2017/02/10 16:04:27]

nit: While you're here, you could remove this static_cast (it's a little weird
to use static_cast to upcast). But that's not really part of this CL.

[adithyas, 2017/02/10 18:39:49]

Removed it.

   if (V8EventTarget::hasInstance(value, isolate)) {
     v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
-    return toWrapperTypeInfo(object)->toEventTarget(object);
+    return EventTarget::toEventTarget(object);

[jbroman, 2017/02/10 16:03:16]

Given that, you can inline the other toEventTarget here, as it becomes the sole
call site (at which point the hasInstance and the eventTargetInheritance bit are
redundant). So after inlining that here, you won't need any changes to
EventTarget.h and EventTarget.cpp.

If that all seems reasonable, we might be able to remove the
eventTargetInheritance bit from WrapperTypeInfo in a followup CL.

[adithyas, 2017/02/10 18:39:49]

Done! I'll remove the wrapperType eventTargetInheritance check (and the field
itself) in a separate CL.

   }
   return 0;
 }
 
 void toFlexibleArrayBufferView(v8::Isolate* isolate,
                                v8::Local<v8::Value> value,
                                FlexibleArrayBufferView& result,
                                void* storage) {
   ASSERT(value->IsArrayBufferView());
   v8::Local<v8::ArrayBufferView> buffer = value.As<v8::ArrayBufferView>();
@@ skipping 200 matching lines @@
   if (!v8Call(v8::JSON::Parse(isolate, v8String(isolate, stringifiedJSON)),
               parsed, tryCatch)) {
     if (tryCatch.HasCaught())
       exceptionState.rethrowV8Exception(tryCatch.Exception());
   }
 
   return parsed;
 }
 
 }  // namespace blink