Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2683953004: Revert of Move surface reference code to CompositorFrameSinkSupport. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move surface reference code to CompositorFrameSinkSupport. (patchset #3 id:60001 of https://codereview.chromium.org/2687433002/ ) Reason for revert: need to revert this to be able to revert https://codereview.chromium.org/2612083002 Original issue's description: > Move surface reference code to CompositorFrameSinkSupport. > > The code that handled adding/removing surface references was in > GpuCompositorFrameSink which is only used with mustash. We want to > experiment with using surface references with non-mustash Chrome, so > move code to CompositorFrameSinkSupport. > > Only add/remove references if SurfaceManager is in surface reference > mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged. > > BUG=676384 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2687433002 > Cr-Commit-Position: refs/heads/master@{#449010} > Committed: https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f764656a0c7b98 TBR=fsamuel@chromium.org,jbauman@chromium.org,kylechar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676384 Review-Url: https://codereview.chromium.org/2683953004 Cr-Commit-Position: refs/heads/master@{#449132} Committed: https://chromium.googlesource.com/chromium/src/+/a398ce6656384abcabbf86fbf06fcb76f67e79dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -104 lines) Patch
M cc/surfaces/compositor_frame_sink_support.h View 3 chunks +0 lines, -19 lines 0 comments Download
M cc/surfaces/compositor_frame_sink_support.cc View 6 chunks +4 lines, -78 lines 0 comments Download
M cc/surfaces/referenced_surface_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/display_compositor/gpu_compositor_frame_sink.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/display_compositor/gpu_compositor_frame_sink.cc View 3 chunks +48 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
jam
Created Revert of Move surface reference code to CompositorFrameSinkSupport.
3 years, 10 months ago (2017-02-08 23:11:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683953004/1
3 years, 10 months ago (2017-02-08 23:12:24 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:17:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a398ce6656384abcabbf86fbf06f...

Powered by Google App Engine
This is Rietveld 408576698