Move surface reference code to CompositorFrameSinkSupport.

Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Original-Commit-Position: refs/heads/master@{#449010}
Committed: https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f764656a0c7b98
Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449336}
Committed: https://chromium.googlesource.com/chromium/src/+/178e459f4e385a22b73a4914ca1c290331d8fb0b

[kylechar, 2017-02-07 14:54:50]

Description was changed from

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink before. This is only used in mustash currently.
We want to experiment with using surface references with non-mustash
Chrome so move code into CompositorFrameSinkSupport since it will be
eventually be used everywhere. Only add/remove references if
SurfaceManager is in surface reference mode, otherwise behaviour in
CompositorFrameSink is unchanged.

BUG=676384
==========

to

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink before. This is only used in mustash currently.
We want to experiment with using surface references with non-mustash
Chrome so move code into CompositorFrameSinkSupport since it will be
eventually be used everywhere. Only add/remove references if
SurfaceManager is in surface reference mode, otherwise behaviour in
CompositorFrameSink is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-02-07 15:09:48]

Description was changed from

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink before. This is only used in mustash currently.
We want to experiment with using surface references with non-mustash
Chrome so move code into CompositorFrameSinkSupport since it will be
eventually be used everywhere. Only add/remove references if
SurfaceManager is in surface reference mode, otherwise behaviour in
CompositorFrameSink is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[kylechar, 2017-02-07 15:16:19]

Patchset #2 (id:20001) has been deleted

[kylechar, 2017-02-07 15:18:11]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org, jbauman@chromium.org

[kylechar, 2017-02-07 15:18:34]

jbauman: OWNERS review
fsamuel: FYI

[kylechar, 2017-02-07 15:18:34]

jbauman: OWNERS review
fsamuel: FYI

[Fady Samuel, 2017-02-07 19:22:12]

lgtm

[jbauman, 2017-02-08 00:39:40]

lgtm

[kylechar, 2017-02-08 00:47:28]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 00:47:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 00:51:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:51:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[kylechar, 2017-02-08 14:14:11]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 14:14:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 15:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 15:48:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kylechar, 2017-02-08 15:48:59]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-08 15:49:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2687433002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-08 15:49:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:32:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486568939670480,
"parent_rev": "d57717758fba0a9d1f7b9a8a101d7f50909bec15", "commit_rev":
"cec9e67c67ec7872e95917acf6f764656a0c7b98"}

[commit-bot: I haz the power, 2017-02-08 16:32:53]

Description was changed from

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449010}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...
==========

[commit-bot: I haz the power, 2017-02-08 16:32:55]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...

[jam, 2017-02-08 23:11:40]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2683953004/ by jam@chromium.org.

The reason for reverting is: need to revert this to be able to revert
https://codereview.chromium.org/2612083002.

[kylechar, 2017-02-09 15:21:22]

Description was changed from

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449010}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...
==========

to

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449010}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...
==========

[kylechar, 2017-02-09 15:21:26]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 15:21:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kylechar, 2017-02-09 15:25:30]

I've reopened the issue and reverted back to patch #2 in order to reland without
https://crrev.com/2612083002.

[commit-bot: I haz the power, 2017-02-09 16:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 16:48:53]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[kylechar, 2017-02-09 16:49:14]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2017-02-09 16:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2687433002/#ps80001
(title: "Revert to patch 2 to reland.")

[commit-bot: I haz the power, 2017-02-09 16:49:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 17:26:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486658954454210,
"parent_rev": "a0b4a2ec8a1aae4f78d196a8a38f929079a99120", "commit_rev":
"178e459f4e385a22b73a4914ca1c290331d8fb0b"}

[commit-bot: I haz the power, 2017-02-09 17:26:50]

Description was changed from

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449010}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...
==========

to

==========
Move surface reference code to CompositorFrameSinkSupport.

The code that handled adding/removing surface references was in
GpuCompositorFrameSink which is only used with mustash. We want to
experiment with using surface references with non-mustash Chrome, so
move code to CompositorFrameSinkSupport.

Only add/remove references if SurfaceManager is in surface reference
mode, otherwise behaviour in CompositorFrameSinkSupport is unchanged.

BUG=676384
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2687433002
Cr-Original-Commit-Position: refs/heads/master@{#449010}
Committed:
https://chromium.googlesource.com/chromium/src/+/cec9e67c67ec7872e95917acf6f7...
Review-Url: https://codereview.chromium.org/2687433002
Cr-Commit-Position: refs/heads/master@{#449336}
Committed:
https://chromium.googlesource.com/chromium/src/+/178e459f4e385a22b73a4914ca1c...
==========

[commit-bot: I haz the power, 2017-02-09 17:26:51]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/178e459f4e385a22b73a4914ca1c...