Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2683853003: Remove unused function for extracting colors from a favicon on Android. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
Ted C
CC:
chromium-reviews, browser-components-watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused function for extracting colors from a favicon on Android. BUG=689704 Review-Url: https://codereview.chromium.org/2683853003 Cr-Commit-Position: refs/heads/master@{#449004} Committed: https://chromium.googlesource.com/chromium/src/+/ade507ebc96b7ac8a1cfcf2f265e715174967567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/android/favicon_helper.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Evan Stade
3 years, 10 months ago (2017-02-07 23:20:40 UTC) #4
Ted C
lgtm
3 years, 10 months ago (2017-02-08 05:33:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683853003/1
3 years, 10 months ago (2017-02-08 16:04:25 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 16:09:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ade507ebc96b7ac8a1cfcf2f265e...

Powered by Google App Engine
This is Rietveld 408576698