Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

Issue 2683853003: Remove unused function for extracting colors from a favicon on Android. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/favicon_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
index 3fbc9a5544fd3eb47ce1ed39e7a75821aa23c1d9..15adc903cbe0eacac5fcbf674e9a31f8110526fb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.favicon;
import android.graphics.Bitmap;
-import android.graphics.Color;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.profiles.Profile;
@@ -92,15 +91,6 @@ public class FaviconHelper {
}
/**
- * Return the dominant color of a given bitmap in {@link Color} format.
- * @param image The bitmap image to find the dominant color for.
- * @return The dominant color in {@link Color} format.
- */
- public static int getDominantColorForBitmap(Bitmap image) {
- return nativeGetDominantColorForBitmap(image);
- }
-
- /**
* Get 16x16 Favicon bitmap for the requested arguments. Only retrives favicons in synced
* session storage. (e.g. favicons synced from other devices).
* TODO(apiccion): provide a way to obtain higher resolution favicons.
@@ -139,7 +129,6 @@ public class FaviconHelper {
FaviconImageCallback faviconImageCallback);
private static native Bitmap nativeGetSyncedFaviconImageForURL(long nativeFaviconHelper,
Profile profile, String pageUrl);
- private static native int nativeGetDominantColorForBitmap(Bitmap image);
private static native void nativeEnsureIconIsAvailable(long nativeFaviconHelper,
Profile profile, WebContents webContents, String pageUrl, String iconUrl,
boolean isLargeIcon, boolean isTemporary, IconAvailabilityCallback callback);
« no previous file with comments | « no previous file | chrome/browser/android/favicon_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698