Keep the aspect ratio of child with percentage max-height when the size of its container changes

Keep the aspect ratio of child with percentage max-height when the size of its container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html

Review-Url: https://codereview.chromium.org/2683793007
Cr-Commit-Position: refs/heads/master@{#450145}
Committed: https://chromium.googlesource.com/chromium/src/+/6da27d806a2386ab7baacf5692727ffa0a7706ca

[Gleb Lanbin, 2017-02-09 22:28:35]

Description was changed from

==========
Keep the aspect ratio of image with percentage max-height when the size of its
container changes

BUG=677942
==========

to

==========
Keep the aspect ratio of image with percentage max-height when the size of its
container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html
==========

[Gleb Lanbin, 2017-02-09 22:29:02]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 22:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2017-02-09 22:29:44]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:10:55]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-02-13 19:28:16]

Patchset #2 (id:20001) has been deleted

[Gleb Lanbin, 2017-02-13 19:28:28]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:29:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2017-02-13 19:29:26]

Description was changed from

==========
Keep the aspect ratio of image with percentage max-height when the size of its
container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html
==========

to

==========
Keep the aspect ratio of child with percentage max-height when the size of its
container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html
==========

[cbiesinger, 2017-02-13 19:37:18]

lgtm

I don't think it would be sufficient to expand the !hasAuto...() check to also
check for max-height, because then we would still have an issue when the height
becomes indefinite. And laying out an image or canvas is fast.

[commit-bot: I haz the power, 2017-02-13 20:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:56:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2017-02-13 21:05:00]

Patchset #2 (id:40001) has been deleted

[Gleb Lanbin, 2017-02-13 21:05:05]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:02:49]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2017-02-13 23:03:23]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-02-13 23:03:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2683793007/#ps60001
(title: "Updated LayoutReplaced::needsPreferredWidthsRecalculation")

[commit-bot: I haz the power, 2017-02-13 23:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:18:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487027003718770,
"parent_rev": "bc6e379f8e228ee5a137e2ee3ff89b973a3494ef", "commit_rev":
"6da27d806a2386ab7baacf5692727ffa0a7706ca"}

[commit-bot: I haz the power, 2017-02-13 23:19:29]

Description was changed from

==========
Keep the aspect ratio of child with percentage max-height when the size of its
container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html
==========

to

==========
Keep the aspect ratio of child with percentage max-height when the size of its
container changes

BUG=677942
TEST=fast/replaced/aspect-ratio-of-replaced-child-with-max-height.html

Review-Url: https://codereview.chromium.org/2683793007
Cr-Commit-Position: refs/heads/master@{#450145}
Committed:
https://chromium.googlesource.com/chromium/src/+/6da27d806a2386ab7baacf569272...
==========

[commit-bot: I haz the power, 2017-02-13 23:19:34]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6da27d806a2386ab7baacf569272...