third_party/WebKit/Source/core/layout/LayoutReplaced.cpp - Issue 2683793007: Keep the aspect ratio of child with percentage max-height when the size of its container changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

Issue 2683793007: Keep the aspect ratio of child with percentage max-height when the size of its container changes (Closed)

Patch Set: Updated LayoutReplaced::needsPreferredWidthsRecalculation Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp b/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

index 9f10ae51d040d384e469528d75cff5360f3fd769..9350529832c0d4be90d013796a33584262e1bac3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp

@@ -132,8 +132,7 @@ bool LayoutReplaced::needsPreferredWidthsRecalculation() const {

// If the height is a percentage and the width is auto, then the

// containingBlocks's height changing can cause this node to change it's

// preferred width because it maintains aspect ratio.

- return hasRelativeLogicalHeight() && style()->logicalWidth().isAuto() &&

- !hasAutoHeightOrContainingBlockWithAutoHeight();

+ return hasRelativeLogicalHeight() && style()->logicalWidth().isAuto();

}

static inline bool layoutObjectHasAspectRatio(