Let disabled/terminated extensions show ErrorConsole.

Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526, 518053
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2683793005
Cr-Commit-Position: refs/heads/master@{#452202}
Committed: https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb20418dd04862

[lazyboy, 2017-02-09 01:08:39]

Description was changed from

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
==========

to

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[lazyboy, 2017-02-09 01:09:58]

lazyboy@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[lazyboy, 2017-02-17 22:55:08]

Description was changed from

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526,518053
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2017-02-17 23:19:39]

lgtm; sorry for letting this one slip!

[lazyboy, 2017-02-17 23:21:50]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 23:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 01:25:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 01:25:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[lazyboy, 2017-02-22 18:36:54]

The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 18:37:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:24:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:24:32]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-02-22 21:09:23]

The CQ bit was checked by lazyboy@chromium.org

[lazyboy, 2017-02-22 21:09:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2683793005/#ps20001
(title: "sync")

[commit-bot: I haz the power, 2017-02-22 21:10:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:17:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487797763159180,
"parent_rev": "eb7fb3d6e52e28883eff0aa08874deef99e7405c", "commit_rev":
"183e1abfdf73580495e0b157cdeb20418dd04862"}

[commit-bot: I haz the power, 2017-02-22 21:17:59]

Description was changed from

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526,518053
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Let disabled/terminated extensions show ErrorConsole.

Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004

Error console shows up for those extensions with this change.

BUG=482526,518053
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2683793005
Cr-Commit-Position: refs/heads/master@{#452202}
Committed:
https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb...
==========

[commit-bot: I haz the power, 2017-02-22 21:18:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb...