|
|
DescriptionLet disabled/terminated extensions show ErrorConsole.
Right now clicking on "Errors" link of a disabled/terminated extension
in chrome://extensions does nothing and throws a JS error:
"Uncaught TypeError: Cannot read property 'manifestErrors' of undefined"
Because we filter out any extension that is not in state
ExtensionState.ENABLED.
This CL removes the filtering that was introduced in the beginning afaik:
https://codereview.chromium.org/1016413004
Error console shows up for those extensions with this change.
BUG=482526, 518053
Test=Make an extension have "Errors" link under chrome://extensions. e.g.
by loading an extension that logs to console. Then 1) disable the
extension. 2) terminate the extension from Task Manager.
Now click on the "Errors" link again. It will show the error console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2683793005
Cr-Commit-Position: refs/heads/master@{#452202}
Committed: https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb20418dd04862
Patch Set 1 #Patch Set 2 : sync #
Messages
Total messages: 19 (15 generated)
Description was changed from ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. ========== to ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lazyboy@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Description was changed from ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526,518053 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm; sorry for letting this one slip!
The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by lazyboy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lazyboy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/2683793005/#ps20001 (title: "sync")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487797763159180, "parent_rev": "eb7fb3d6e52e28883eff0aa08874deef99e7405c", "commit_rev": "183e1abfdf73580495e0b157cdeb20418dd04862"}
Message was sent while issue was closed.
Description was changed from ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526,518053 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Let disabled/terminated extensions show ErrorConsole. Right now clicking on "Errors" link of a disabled/terminated extension in chrome://extensions does nothing and throws a JS error: "Uncaught TypeError: Cannot read property 'manifestErrors' of undefined" Because we filter out any extension that is not in state ExtensionState.ENABLED. This CL removes the filtering that was introduced in the beginning afaik: https://codereview.chromium.org/1016413004 Error console shows up for those extensions with this change. BUG=482526,518053 Test=Make an extension have "Errors" link under chrome://extensions. e.g. by loading an extension that logs to console. Then 1) disable the extension. 2) terminate the extension from Task Manager. Now click on the "Errors" link again. It will show the error console. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2683793005 Cr-Commit-Position: refs/heads/master@{#452202} Committed: https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/183e1abfdf73580495e0b157cdeb... |