Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2683753003: Revert of test262 roll (Closed)

Created:
3 years, 10 months ago by Dan Ehrenberg
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of test262 roll (patchset #1 id:1 of https://codereview.chromium.org/2681833003/ ) Reason for revert: Oops, looks like the patch to change the name of $ to $262 isn't merged yet. Not sure why this didn't cause a bunch of failures--need to investigate. Reverting for now. Original issue's description: > test262 roll > > This patch changes tests right up until the SharedArrayBuffer > tests. > > R=adamk > > Review-Url: https://codereview.chromium.org/2681833003 > Cr-Commit-Position: refs/heads/master@{#43019} > Committed: https://chromium.googlesource.com/v8/v8/+/9588a0de5a356b8d7f467dc8000e933afd778caa TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2683753003 Cr-Commit-Position: refs/heads/master@{#43020} Committed: https://chromium.googlesource.com/v8/v8/+/4d7856d9ed3cc37042265ce57d0feb645625bbad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/detachArrayBuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/harness-adapt.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 5 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Dan Ehrenberg
Created Revert of test262 roll
3 years, 10 months ago (2017-02-07 23:32:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683753003/1
3 years, 10 months ago (2017-02-07 23:33:02 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:33:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4d7856d9ed3cc37042265ce57d0feb64562...

Powered by Google App Engine
This is Rietveld 408576698