Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2681833003: test262 roll (Closed)

Created:
3 years, 10 months ago by Dan Ehrenberg
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

test262 roll This patch changes tests right up until the SharedArrayBuffer tests. R=adamk Review-Url: https://codereview.chromium.org/2681833003 Cr-Commit-Position: refs/heads/master@{#43019} Committed: https://chromium.googlesource.com/v8/v8/+/9588a0de5a356b8d7f467dc8000e933afd778caa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/detachArrayBuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/harness-adapt.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 5 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Dan Ehrenberg
3 years, 10 months ago (2017-02-07 20:03:08 UTC) #2
adamk
lgtm Guessing we'll need more harness support for SAB tests?
3 years, 10 months ago (2017-02-07 20:56:14 UTC) #10
Dan Ehrenberg
On 2017/02/07 20:56:14, adamk wrote: > lgtm > > Guessing we'll need more harness support ...
3 years, 10 months ago (2017-02-07 23:15:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681833003/1
3 years, 10 months ago (2017-02-07 23:16:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/9588a0de5a356b8d7f467dc8000e933afd778caa
3 years, 10 months ago (2017-02-07 23:17:45 UTC) #16
Dan Ehrenberg
3 years, 10 months ago (2017-02-07 23:32:54 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2683753003/ by littledan@chromium.org.

The reason for reverting is: Oops, looks like the patch to change the name of $
to $262 isn't merged yet. Not sure why this didn't cause a bunch of
failures--need to investigate. Reverting for now..

Powered by Google App Engine
This is Rietveld 408576698