[parser/test] Move cctest/PreParserScopeAnalysis into a new file.

[parser/test] Move cctest/PreParserScopeAnalysis into a new file.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2683573002
Cr-Commit-Position: refs/heads/master@{#42986}
Committed: https://chromium.googlesource.com/v8/v8/+/009e8b11e25c658b5990df54d146abe7ad11d666

[marja, 2017-02-07 08:58:43]

ptal

[vogelheim, 2017-02-07 09:11:23]

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser.cc
File test/cctest/test-preparser.cc (right):

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser....
test/cctest/test-preparser.cc:1: // Copyright 2017 the V8 project authors. All
rights reserved.
I'd be slightly happier if this file were in the parsing/ subdir, i.e.,
test/cctest/parsing/test-preparser.cc.

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser....
test/cctest/test-preparser.cc:26: int suffix_len = Utf8LengthHelper(suffix);
nitpick, and entirely unrelated to this CL: With the given prefix/suffix, strlen
would compute the length just fine.

[vogelheim, 2017-02-07 09:16:17]

lgtm

[neis, 2017-02-07 09:47:25]

The CQ bit was checked by neis@chromium.org

[neis, 2017-02-07 09:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2683573002/#ps20001
(title: "move a file")

[commit-bot: I haz the power, 2017-02-07 09:47:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2017-02-07 09:59:37]

There are a few other preparser-only tests in test-parsing.cc, maybe you can
move them as well.

[commit-bot: I haz the power, 2017-02-07 10:11:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486460845596400,
"parent_rev": "7d15175a0f59dfc15cf811a45e358dd4cc9b36e9", "commit_rev":
"009e8b11e25c658b5990df54d146abe7ad11d666"}

[commit-bot: I haz the power, 2017-02-07 10:11:06]

Description was changed from

==========
[parser/test] Move cctest/PreParserScopeAnalysis into a new file.

BUG=v8:5516
R=vogelheim@chromium.org
==========

to

==========
[parser/test] Move cctest/PreParserScopeAnalysis into a new file.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2683573002
Cr-Commit-Position: refs/heads/master@{#42986}
Committed:
https://chromium.googlesource.com/v8/v8/+/009e8b11e25c658b5990df54d146abe7ad1...
==========

[commit-bot: I haz the power, 2017-02-07 10:11:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/009e8b11e25c658b5990df54d146abe7ad1...

[marja, 2017-02-07 13:38:14]

thanks for review

I intentionally didn't move other tests; trying to not spend too much energy on
test reorganization and simultaneously be a good... or at least a non-horrible
citizen.

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser.cc
File test/cctest/test-preparser.cc (right):

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser....
test/cctest/test-preparser.cc:1: // Copyright 2017 the V8 project authors. All
rights reserved.
On 2017/02/07 09:11:23, vogelheim wrote:
> I'd be slightly happier if this file were in the parsing/ subdir, i.e.,
> test/cctest/parsing/test-preparser.cc.

Done.

https://codereview.chromium.org/2683573002/diff/1/test/cctest/test-preparser....
test/cctest/test-preparser.cc:26: int suffix_len = Utf8LengthHelper(suffix);
On 2017/02/07 09:11:23, vogelheim wrote:
> nitpick, and entirely unrelated to this CL: With the given prefix/suffix,
strlen
> would compute the length just fine.

Lol, this was some brainless copy paste...

However, kept this as is. Probably makes sense to move the utf helpers anyway.