[parser] Skipping inner funcs: produce the same scopes / variables for this expressions.

[parser] Skipping inner funcs: produce the same scopes / variables for this expressions.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2683563002
Cr-Commit-Position: refs/heads/master@{#42983}
Committed: https://chromium.googlesource.com/v8/v8/+/44a381ad9995f90bc2ed61c398243acd054648b2

[marja, 2017-02-07 08:23:16]

ptal

https://codereview.chromium.org/2683563002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (left):

https://codereview.chromium.org/2683563002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:9438: // FIXME(marja): Add test cases for special
variables (this, arguments
This was a red herring; turns out this expressions didn't work at all, unrelated
to loops. So I added tests above.

[vogelheim, 2017-02-07 08:33:47]

lgtm

https://codereview.chromium.org/2683563002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (left):

https://codereview.chromium.org/2683563002/diff/1/test/cctest/test-parsing.cc...
test/cctest/test-parsing.cc:9438: // FIXME(marja): Add test cases for special
variables (this, arguments
On 2017/02/07 08:23:16, marja wrote:
> This was a red herring; turns out this expressions didn't work at all,
unrelated
> to loops. So I added tests above.

Acknowledged.

[marja, 2017-02-07 08:36:00]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2017-02-07 08:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 09:14:57]

CQ is committing da patch.

Bot data: {"patchset_id": 10003, "attempt_start_ts": 1486456560420600,
"parent_rev": "ef4e2ab7bd75eae60e8ab2e7757e0772c4d00efd", "commit_rev":
"44a381ad9995f90bc2ed61c398243acd054648b2"}

[commit-bot: I haz the power, 2017-02-07 09:15:00]

Description was changed from

==========
[parser] Skipping inner funcs: produce the same scopes / variables for this
expressions.

BUG=v8:5516
R=vogelheim@chromium.org
==========

to

==========
[parser] Skipping inner funcs: produce the same scopes / variables for this
expressions.

BUG=v8:5516
R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2683563002
Cr-Commit-Position: refs/heads/master@{#42983}
Committed:
https://chromium.googlesource.com/v8/v8/+/44a381ad9995f90bc2ed61c398243acd054...
==========

[commit-bot: I haz the power, 2017-02-07 09:15:01]

Committed patchset #2 (id:10003) as
https://chromium.googlesource.com/v8/v8/+/44a381ad9995f90bc2ed61c398243acd054...