Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2683543005: Revert of Use TaskScheduler instead of blocking pool in wizard_controller.cc. (patchset #3 id:40001… (Closed)

Created:
3 years, 10 months ago by Greg Levin
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3005
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of blocking pool in wizard_controller.cc. (patchset #3 id:40001 of https://codereview.chromium.org/2671263002/ ) Reason for revert: Compile failure on official builds. Link: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29028/ error like wizard_controller.cc:727:7:error: invalid argument type 'void' to unary expression Original issue's description: > Use TaskScheduler instead of blocking pool in wizard_controller.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=alemate@chromium.org > > Review-Url: https://codereview.chromium.org/2671263002 > Cr-Commit-Position: refs/heads/master@{#448504} > Committed: https://chromium.googlesource.com/chromium/src/+/51464e865861790a1c332b8fc0d7ad7824dd3170 TBR=alemate@chromium.org,fdoray@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2678243002 Cr-Commit-Position: refs/heads/master@{#448516} (cherry picked from commit 7eea8952954c9b0db9ac932efc2389ba793c6e55) Review-Url: https://codereview.chromium.org/2683543005 . Cr-Commit-Position: refs/branch-heads/3005@{#8} Cr-Branched-From: 75481c5507579245a81f8b75298a17a269fce1fa-refs/heads/master@{#448507} Committed: https://chromium.googlesource.com/chromium/src/+/3c32ea67cbe6f6e95f98b00c935d7c56459ed70c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Greg Levin
3 years, 10 months ago (2017-02-07 22:10:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c32ea67cbe6f6e95f98b00c935d7c56459ed70c.

Powered by Google App Engine
This is Rietveld 408576698