Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2678243002: Revert of Use TaskScheduler instead of blocking pool in wizard_controller.cc. (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of blocking pool in wizard_controller.cc. (patchset #3 id:40001 of https://codereview.chromium.org/2671263002/ ) Reason for revert: Compile failure on official builds. Link: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29028/ error like wizard_controller.cc:727:7:error: invalid argument type 'void' to unary expression Original issue's description: > Use TaskScheduler instead of blocking pool in wizard_controller.cc. > > The blocking pool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=alemate@chromium.org > > Review-Url: https://codereview.chromium.org/2671263002 > Cr-Commit-Position: refs/heads/master@{#448504} > Committed: https://chromium.googlesource.com/chromium/src/+/51464e865861790a1c332b8fc0d7ad7824dd3170 TBR=alemate@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2678243002 Cr-Commit-Position: refs/heads/master@{#448516} Committed: https://chromium.googlesource.com/chromium/src/+/7eea8952954c9b0db9ac932efc2389ba793c6e55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tapted
Created Revert of Use TaskScheduler instead of blocking pool in wizard_controller.cc.
3 years, 10 months ago (2017-02-07 02:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2678243002/1
3 years, 10 months ago (2017-02-07 02:25:04 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 02:26:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7eea8952954c9b0db9ac932efc23...

Powered by Google App Engine
This is Rietveld 408576698