Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2683543002: Revert changes to download_prefs regarding PDF auto open. (Closed)

Created:
3 years, 10 months ago by pastarmovj
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert changes to download_prefs regarding PDF auto open. In https://codereview.chromium.org/2369353002/ we introduced logic to automatically open the program associated with PDF when the always open PDF in external viewer was selected. This causes some issues where saving of PDFs becomes harder or cumbersome. Until we figre better way to decided when to auto-open and when not revert this logic. BUG=680202 TEST=This is revert to existing state covered by existing tests. Review-Url: https://codereview.chromium.org/2669773002 Cr-Commit-Position: refs/heads/master@{#447773} (cherry picked from commit 7c93dbe0d5fe53372321fa53368377ee6770405a) Review-Url: https://codereview.chromium.org/2683543002 . Cr-Commit-Position: refs/branch-heads/2987@{#356} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/58f25776d2ee7cacc0a3d0a6a9be90184d944adf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -32 lines) Patch
M chrome/browser/download/download_prefs.h View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/download/download_prefs.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/download/download_prefs_unittest.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
3 years, 10 months ago (2017-02-07 07:39:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58f25776d2ee7cacc0a3d0a6a9be90184d944adf (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698