Revert changes to DownloadPrefs regarding PDF auto open.

Revert changes to download_prefs regarding PDF auto open.

In https://codereview.chromium.org/2369353002/ we introduced logic
to automatically open the program associated with PDF when the
always open PDF in external viewer was selected. This causes some
issues where saving of PDFs becomes harder or cumbersome.

Until we figre better way to decided when to auto-open and when not
revert this logic.

BUG=680202
TEST=This is revert to existing state covered by existing tests.

Review-Url: https://codereview.chromium.org/2669773002
Cr-Commit-Position: refs/heads/master@{#447773}
Committed: https://chromium.googlesource.com/chromium/src/+/7c93dbe0d5fe53372321fa53368377ee6770405a

[pastarmovj, 2017-02-01 12:24:34]

Description was changed from

==========
Revert changes to download_prefs regarding PDF auto open.

In https://codereview.chromium.org/2369353002/ we introduced logic
to automatically open the program associated with PDF when the
always open PDF in external viewer was selected. This causes some
issues where saving of PDFs becomes harder or cumbersome.

Until we figre better way to decided when to auto-open and when not
revert this logic.

BUG=680202
TEST=This is revert to existing state covered by existing tests.
==========

to

==========
Revert changes to download_prefs regarding PDF auto open.

In https://codereview.chromium.org/2369353002/ we introduced logic
to automatically open the program associated with PDF when the
always open PDF in external viewer was selected. This causes some
issues where saving of PDFs becomes harder or cumbersome.

Until we figre better way to decided when to auto-open and when not
revert this logic.

BUG=680202
TEST=This is revert to existing state covered by existing tests.
==========

[pastarmovj, 2017-02-01 12:27:05]

pastarmovj@chromium.org changed reviewers:
+ asanka@chromium.org

[pastarmovj, 2017-02-01 12:27:05]

Hey Asanka,

What is your oppinion on reverting this until we figure better way to do that
without causing the issues people currently have with downloading pdfs. It only
means that people will have to click on the download to open it for now.

Cheers,
Julian

[pastarmovj, 2017-02-01 13:33:10]

The CQ bit was checked by pastarmovj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 13:33:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 14:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 14:16:36]

Dry run: This issue passed the CQ dry run.

[asanka, 2017-02-01 22:02:15]

LGTM

We'd need to decouple the should_open_pdf_in_system_reader_ and the concept of
"always open PDF files". But I'm okay with reverting this for the short term.

Can you verify that opening a PDF works correctly with
kOpenPdfDownloadInSystemReader set to false and kPluginsAlwaysOpenPdfExternally
set to true?

[pastarmovj, 2017-02-02 13:43:37]

On 2017/02/01 22:02:15, asanka wrote:
> LGTM
> 
> We'd need to decouple the should_open_pdf_in_system_reader_ and the concept of
> "always open PDF files". But I'm okay with reverting this for the short term.
> 
> Can you verify that opening a PDF works correctly with
> kOpenPdfDownloadInSystemReader set to false and
kPluginsAlwaysOpenPdfExternally
> set to true?

Seems to be ok :)

[pastarmovj, 2017-02-02 13:43:45]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2017-02-02 13:43:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 16:14:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486043025569580, "parent_rev":
"bbf5af70f469a5f7807ec4573a65c3710cfbb29a", "commit_rev":
"7c93dbe0d5fe53372321fa53368377ee6770405a"}

[commit-bot: I haz the power, 2017-02-02 16:15:14]

Description was changed from

==========
Revert changes to download_prefs regarding PDF auto open.

In https://codereview.chromium.org/2369353002/ we introduced logic
to automatically open the program associated with PDF when the
always open PDF in external viewer was selected. This causes some
issues where saving of PDFs becomes harder or cumbersome.

Until we figre better way to decided when to auto-open and when not
revert this logic.

BUG=680202
TEST=This is revert to existing state covered by existing tests.
==========

to

==========
Revert changes to download_prefs regarding PDF auto open.

In https://codereview.chromium.org/2369353002/ we introduced logic
to automatically open the program associated with PDF when the
always open PDF in external viewer was selected. This causes some
issues where saving of PDFs becomes harder or cumbersome.

Until we figre better way to decided when to auto-open and when not
revert this logic.

BUG=680202
TEST=This is revert to existing state covered by existing tests.

Review-Url: https://codereview.chromium.org/2669773002
Cr-Commit-Position: refs/heads/master@{#447773}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c93dbe0d5fe53372321fa533683...
==========

[commit-bot: I haz the power, 2017-02-02 16:15:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c93dbe0d5fe53372321fa533683...