Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5301)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index df541103861981443ec90739bcb7acbced0e423a..f722a020c98dc3100f23d73c095d898d97b4adac 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -6,6 +6,8 @@
#define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_PRERENDERING_LOADER_H_
#include <memory>
+#include <string>
+#include <vector>
#include "base/callback.h"
#include "chrome/browser/android/offline_pages/prerender_adapter.h"
@@ -74,6 +76,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// SnapshotController::Client implementation:
void StartSnapshot() override;
+ // TODO: Is this heavyweight enough I should move it instead of copying?
+ const std::vector<std::string>& GetSignalData() { return signal_data_; }
+
private:
// State of the loader (only one request may be active at a time).
enum class State {
@@ -112,6 +117,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// storage namespace for rendering. This will NOT have the loaded page.
std::unique_ptr<content::WebContents> session_contents_;
+ // Signal data collected for this rendering attempt
+ std::vector<std::string> signal_data_;
+
// Callback to call when the active load request completes, fails, or is
// canceled.
LoadPageCallback callback_;

Powered by Google App Engine
This is Rietveld 408576698