Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2683493002: Get signals working in the EXTRA_DATA section of MHTML (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index f6e1b6e435b50bdf91776f1b4446b41b388834fe..91afdffe02730109e3bfc114bc785d55a91d118d 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -149,6 +149,9 @@ void PrerenderingLoader::OnPrerenderStopLoading() {
// Inform SnapshotController of OnLoad event so it can determine
// when to consider it really LOADED.
snapshot_controller_->DocumentOnLoadCompletedInMainFrame();
+
+ // Add this signal to signal_data_.
+ signal_data_.push_back(std::string("OnLoad seen"));
fgorski 2017/02/07 22:06:08 "OnLoad" is enough, as "seen" is implied. How abo
}
void PrerenderingLoader::OnPrerenderDomContentLoaded() {
@@ -162,6 +165,9 @@ void PrerenderingLoader::OnPrerenderDomContentLoaded() {
// determine when to consider it really LOADED (e.g., some multiple
// second delay from this event).
snapshot_controller_->DocumentAvailableInMainFrame();
+
+ // Add this signal to signal_data_.
+ signal_data_.push_back(std::string("DCL seen"));
fgorski 2017/02/07 22:06:08 can you please expand DCL to full name and remove
}
}

Powered by Google App Engine
This is Rietveld 408576698