Get signals working in the EXTRA_DATA section of MHTML

chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
index 27948ae0aa02652fe93f6c0ba118d6737a6b37ca..e3c87d948d16c2843bf769fcc5ef0cb10b28021a 100644
--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
@@ -53,10 +53,12 @@ OfflinePageMHTMLArchiver::~OfflinePageMHTMLArchiver() {
 void OfflinePageMHTMLArchiver::CreateArchive(
     const base::FilePath& archives_dir,
     const CreateArchiveParams& create_archive_params,
+    const std::vector<std::string>& signal_data,
     const CreateArchiveCallback& callback) {
   DCHECK(callback_.is_null());
   DCHECK(!callback.is_null());
   callback_ = callback;
+  signal_data_ = signal_data;

[fgorski, 2017/02/07 22:06:07]

If I understand correctly this will be a copy. Can we avoid that? Perhaps just &
instead of const &, followed by a swap?

[Dmitry Titov, 2017/02/14 20:39:58]

I think this is also equivalent to passing a std::unique_ptr<...>, with the
latter being more explicit about the ownership transferring.

 
   if (HasConnectionSecurityError()) {
     ReportFailure(ArchiverResult::ERROR_SECURITY_CERTIFICATE);
@@ -97,6 +99,7 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(
   content::MHTMLGenerationParams params(file_path);
   params.use_binary_encoding = true;
   params.remove_popup_overlay = create_archive_params.remove_popup_overlay;
+  params.extra_data = signal_data_;

[fgorski, 2017/02/07 22:06:07]

Here as well.

 
   web_contents_->GenerateMHTML(
       params,