Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 2683353003: Run `pub get` with --verbose to debug flaky timeouts on pkg tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 0a86703abb6918ce8010b9cc07322bd022cb93fa..a16141d952f263a1f8a8f51772c5bbf161648d4d 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1929,10 +1929,12 @@ class PkgBuildTestSuite extends TestSuite {
var cacheDir = new Path(checkoutDir).append("pub-cache").toNativePath();
// Build all commands
+ // In order to debug timeouts on the buildbots, We run `pub get` with
+ // "--verbose". See https://github.com/dart-lang/sdk/issues/28734.
var commands = [
CommandBuilder.instance.getCopyCommand(directory, checkoutDir),
CommandBuilder.instance.getPubCommand(
- "get", pubPath, checkoutDir, cacheDir)
+ "get", pubPath, checkoutDir, cacheDir, arguments: ['--verbose'])
];
bool containsWebDirectory = dirExists(directoryPath.append('web'));
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698