Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2683353003: Run `pub get` with --verbose to debug flaky timeouts on pkg tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 52ba4b74c375dca7cc812418c9eab04fb58dce5e..0da9883dc884eae8f51ad17c752ac856cae3dd31 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -452,11 +452,11 @@ class PubCommand extends ProcessCommand {
final String command;
PubCommand._(String pubCommand, String pubExecutable,
- String pubspecYamlDirectory, String pubCacheDirectory)
+ String pubspecYamlDirectory, String pubCacheDirectory, List<String> args)
: super._(
'pub_$pubCommand',
new io.File(pubExecutable).absolute.path,
- [pubCommand],
+ [pubCommand]..addAll(args),
{'PUB_CACHE': pubCacheDirectory},
pubspecYamlDirectory),
command = pubCommand;
@@ -695,9 +695,11 @@ class CommandBuilder {
}
Command getPubCommand(String pubCommand, String pubExecutable,
- String pubspecYamlDirectory, String pubCacheDirectory) {
+ String pubspecYamlDirectory, String pubCacheDirectory,
+ {List<String> arguments: const <String>[]}) {
var command = new PubCommand._(
- pubCommand, pubExecutable, pubspecYamlDirectory, pubCacheDirectory);
+ pubCommand, pubExecutable, pubspecYamlDirectory, pubCacheDirectory,
+ arguments);
return _getUniqueCommand(command);
}
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698