Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 2683353003: Run `pub get` with --verbose to debug flaky timeouts on pkg tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1911 matching lines...) Expand 10 before | Expand all | Expand 10 after
1922 1922
1923 var directoryPath = absoluteDirectoryPath.relativeTo(TestUtils.dartDir); 1923 var directoryPath = absoluteDirectoryPath.relativeTo(TestUtils.dartDir);
1924 var testName = "$directoryPath"; 1924 var testName = "$directoryPath";
1925 var displayName = '$suiteName/$testName'; 1925 var displayName = '$suiteName/$testName';
1926 1926
1927 var checkoutDir = 1927 var checkoutDir =
1928 createPubPackageBuildsDirectory(absoluteDirectoryPath); 1928 createPubPackageBuildsDirectory(absoluteDirectoryPath);
1929 var cacheDir = new Path(checkoutDir).append("pub-cache").toNativePath(); 1929 var cacheDir = new Path(checkoutDir).append("pub-cache").toNativePath();
1930 1930
1931 // Build all commands 1931 // Build all commands
1932 // In order to debug timeouts on the buildbots, We run `pub get` with
1933 // "--verbose". See https://github.com/dart-lang/sdk/issues/28734.
1932 var commands = [ 1934 var commands = [
1933 CommandBuilder.instance.getCopyCommand(directory, checkoutDir), 1935 CommandBuilder.instance.getCopyCommand(directory, checkoutDir),
1934 CommandBuilder.instance.getPubCommand( 1936 CommandBuilder.instance.getPubCommand(
1935 "get", pubPath, checkoutDir, cacheDir) 1937 "get", pubPath, checkoutDir, cacheDir, arguments: ['--verbose'])
1936 ]; 1938 ];
1937 1939
1938 bool containsWebDirectory = dirExists(directoryPath.append('web')); 1940 bool containsWebDirectory = dirExists(directoryPath.append('web'));
1939 bool containsBuildDartFile = 1941 bool containsBuildDartFile =
1940 fileExists(directoryPath.append('build.dart')); 1942 fileExists(directoryPath.append('build.dart'));
1941 if (containsBuildDartFile) { 1943 if (containsBuildDartFile) {
1942 var dartBinary = new File(dartVmBinaryFileName).absolute.path; 1944 var dartBinary = new File(dartVmBinaryFileName).absolute.path;
1943 1945
1944 commands.add(CommandBuilder.instance.getProcessCommand( 1946 commands.add(CommandBuilder.instance.getProcessCommand(
1945 "custom_build", 1947 "custom_build",
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
2420 } 2422 }
2421 if (path.length > WINDOWS_SHORTEN_PATH_LIMIT) { 2423 if (path.length > WINDOWS_SHORTEN_PATH_LIMIT) {
2422 ++shortNameCounter; 2424 ++shortNameCounter;
2423 var pathEnd = path.substring(path.length - WINDOWS_PATH_END_LENGTH); 2425 var pathEnd = path.substring(path.length - WINDOWS_PATH_END_LENGTH);
2424 path = "short${shortNameCounter}_$pathEnd"; 2426 path = "short${shortNameCounter}_$pathEnd";
2425 } 2427 }
2426 } 2428 }
2427 return path; 2429 return path;
2428 } 2430 }
2429 } 2431 }
OLDNEW
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698