Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2683313002: Remove non-MD test coverage from chrome/browser/ui/ (Closed)

Created:
3 years, 10 months ago by mohsen
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-MD test coverage from chrome/browser/ui/ Now that Material Design mode for Ash is on by default, we can remove non-MD test coverage. BUG=685837 TEST=SystemTrayDelegateChromeOSTest.*, BrowserNonClientFrameViewAshTest.* in browser_tests, ImmersiveModeControllerAshTest.* in unit_tests Review-Url: https://codereview.chromium.org/2683313002 Cr-Commit-Position: refs/heads/master@{#449522} Committed: https://chromium.googlesource.com/chromium/src/+/97f5c688fee9e12927c7deed091350fbe27f531f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -79 lines) Patch
M chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc View 2 chunks +13 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc View 4 chunks +8 lines, -33 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mohsen
Please take a look...
3 years, 10 months ago (2017-02-09 22:46:10 UTC) #4
sky
LGTM
3 years, 10 months ago (2017-02-10 00:02:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683313002/1
3 years, 10 months ago (2017-02-10 02:15:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/97f5c688fee9e12927c7deed091350fbe27f531f
3 years, 10 months ago (2017-02-10 02:25:17 UTC) #12
Qiang(Joe) Xu
3 years, 10 months ago (2017-02-16 23:00:39 UTC) #13
Message was sent while issue was closed.
On 2017/02/10 02:25:17, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/97f5c688fee9e12927c7deed0913...

Hi moshen@, could you (or I can do it) merge this CL to M57? I need to merge
https://codereview.chromium.org/2690443002/ to M57. It will help if this CL is
merged to M57.

Powered by Google App Engine
This is Rietveld 408576698