chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc - Issue 2683313002: Remove non-MD test coverage from chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Issue 2683313002: Remove non-MD test coverage from chrome/browser/ui/ (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

index 351229a16b19775b163512740d497b70877ed89d..778e5e8f43a900b6d0c2653d53fbaafb6a9bfade 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

@@ -7,7 +7,6 @@

#include "ash/common/ash_constants.h"

#include "ash/common/frame/caption_buttons/frame_caption_button_container_view.h"

#include "ash/common/frame/header_painter.h"

-#include "ash/common/material_design/material_design_controller.h"

#include "ash/common/wm/maximize_mode/maximize_mode_controller.h"

#include "ash/common/wm_shell.h"

#include "ash/shell.h"

@@ -196,21 +195,12 @@ IN_PROC_BROWSER_TEST_F(BrowserNonClientFrameViewAshTest, ImmersiveFullscreen) {

EXPECT_LT(Tab::GetImmersiveHeight(),

frame_view->header_painter_->GetHeaderHeightForPainting());

- // Ending the reveal. In MD, immersive browser should have the same behavior

- // as full screen, i.e., no light bar and having an origin of (0,0). In

- // non-MD, immersive browser will show a 3 dp light bar on the top.

+ // Ending the reveal. Immersive browser should have the same behavior as full

+ // screen, i.e., no light bar and having an origin of (0,0).

revealed_lock.reset();

- if (ash::MaterialDesignController::IsImmersiveModeMaterial()) {

- EXPECT_FALSE(frame_view->ShouldPaint());

- EXPECT_FALSE(frame_view->UseImmersiveLightbarHeaderStyle());

- EXPECT_EQ(0, frame_view->header_painter_->GetHeaderHeightForPainting());

- } else {

- EXPECT_TRUE(frame_view->ShouldPaint());

- EXPECT_FALSE(frame_view->caption_button_container_->visible());

- EXPECT_TRUE(frame_view->UseImmersiveLightbarHeaderStyle());

- EXPECT_EQ(Tab::GetImmersiveHeight(),

- frame_view->header_painter_->GetHeaderHeightForPainting());

- }

+ EXPECT_FALSE(frame_view->ShouldPaint());

+ EXPECT_FALSE(frame_view->UseImmersiveLightbarHeaderStyle());

+ EXPECT_EQ(0, frame_view->header_painter_->GetHeaderHeightForPainting());

// Exiting immersive fullscreen should make the caption buttons and the frame

// visible again.