Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2683233006: DevTools: Fix button layout glitches on Memory panel. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix button layout glitches on Memory panel. BUG=680888 Review-Url: https://codereview.chromium.org/2683233006 Cr-Commit-Position: refs/heads/master@{#449501} Committed: https://chromium.googlesource.com/chromium/src/+/21f5e38c079d7bed76f88b5ca25b0bb142d45aff

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css View 1 2 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
alph
3 years, 10 months ago (2017-02-09 22:23:37 UTC) #2
caseq
lgtm https://codereview.chromium.org/2683233006/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css File third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css (right): https://codereview.chromium.org/2683233006/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css#newcode132 third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css:132: .profile-launcher-target * { .profile-launcher-target > *
3 years, 10 months ago (2017-02-09 23:12:22 UTC) #3
alph
https://codereview.chromium.org/2683233006/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css File third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css (right): https://codereview.chromium.org/2683233006/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css#newcode132 third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css:132: .profile-launcher-target * { On 2017/02/09 23:12:22, caseq wrote: > ...
3 years, 10 months ago (2017-02-09 23:40:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683233006/20001
3 years, 10 months ago (2017-02-09 23:40:43 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 01:21:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/21f5e38c079d7bed76f88b5ca25b...

Powered by Google App Engine
This is Rietveld 408576698