Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js

Issue 2683233006: DevTools: Fix button layout glitches on Memory panel. (Closed)
Patch Set: addressing comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
index cfd28b059a1774fad10adc12fb6feb881868a08e..9dcb21787627ae5fb1f503b7bae6b34ea1c6d05e 100644
--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
@@ -45,13 +45,13 @@ Profiler.ProfileLauncherView = class extends UI.VBox {
this._contentElement = this.element.createChild('div', 'profile-launcher-view-content');
this._innerContentElement = this._contentElement.createChild('div');
- var targetSpan = this._contentElement.createChild('span');
- var selectTargetText = targetSpan.createChild('span');
- selectTargetText.textContent = Common.UIString('Target:');
- var targetsSelect = targetSpan.createChild('select', 'chrome-select');
- new Profiler.TargetsComboBoxController(targetsSelect, targetSpan);
- this._controlButton = UI.createTextButton('', this._controlButtonClicked.bind(this), 'control-profiling');
- this._contentElement.appendChild(this._controlButton);
+ var controlDiv = this._contentElement.createChild('div', 'hbox profile-launcher-control');
+ var targetDiv = controlDiv.createChild('div', 'hbox profile-launcher-target');
+ targetDiv.createChild('div').textContent = Common.UIString('Target:');
+ var targetsSelect = targetDiv.createChild('select', 'chrome-select');
+ new Profiler.TargetsComboBoxController(targetsSelect, targetDiv);
+ this._controlButton = UI.createTextButton('', this._controlButtonClicked.bind(this));
+ controlDiv.appendChild(this._controlButton);
this._recordButtonEnabled = true;
this._loadButton = UI.createTextButton(Common.UIString('Load'), this._loadButtonClicked.bind(this), 'load-profile');
this._contentElement.appendChild(this._loadButton);
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698