Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2683203002: Revert of [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
Jarin, Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation (patchset #3 id:40001 of https://codereview.chromium.org/2682143002/ ) Reason for revert: cfi failure: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/8635 Original issue's description: > [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation > > BUG= > > Review-Url: https://codereview.chromium.org/2682143002 > Cr-Commit-Position: refs/heads/master@{#43065} > Committed: https://chromium.googlesource.com/v8/v8/+/193a0c118845d068ab386b5c90d04daaa64e1e86 TBR=jarin@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2683203002 Cr-Commit-Position: refs/heads/master@{#43070} Committed: https://chromium.googlesource.com/v8/v8/+/1837cf49648c176aac1ef761044c49820d860c84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+279 lines, -329 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 6 chunks +9 lines, -11 lines 0 comments Download
M src/compiler/code-generator.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/code-generator.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/common-operator.cc View 5 chunks +74 lines, -64 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/graph-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/graph-assembler.cc View 1 chunk +6 lines, -13 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/instruction.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 5 chunks +23 lines, -14 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 4 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation
3 years, 10 months ago (2017-02-09 18:05:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683203002/1
3 years, 10 months ago (2017-02-09 18:05:32 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 18:05:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1837cf49648c176aac1ef761044c49820d8...

Powered by Google App Engine
This is Rietveld 408576698