Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2682143002: [compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation (Closed)

Created:
3 years, 10 months ago by Toon Verwaest
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Pass deoptimization_kind through DeoptimizeParameters and FlagsContinuation BUG= Review-Url: https://codereview.chromium.org/2682143002 Cr-Original-Commit-Position: refs/heads/master@{#43065} Committed: https://chromium.googlesource.com/v8/v8/+/193a0c118845d068ab386b5c90d04daaa64e1e86 Review-Url: https://codereview.chromium.org/2682143002 Cr-Commit-Position: refs/heads/master@{#43085} Committed: https://chromium.googlesource.com/v8/v8/+/b8c7870c1e803612bdcacaea3359627e5235155d

Patch Set 1 #

Patch Set 2 : Fix up cache #

Patch Set 3 : Fixes #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+330 lines, -290 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 7 chunks +12 lines, -10 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M src/compiler/branch-elimination.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/code-generator.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/code-generator.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 3 2 chunks +3 lines, -12 lines 0 comments Download
M src/compiler/common-operator.cc View 1 2 3 6 chunks +62 lines, -78 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/graph-assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/graph-assembler.cc View 1 chunk +13 lines, -6 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/instruction.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector.cc View 5 chunks +14 lines, -23 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 4 chunks +11 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 5 chunks +10 lines, -8 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 7 chunks +12 lines, -10 lines 0 comments Download
M src/globals.h View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Toon Verwaest
ptal
3 years, 10 months ago (2017-02-08 16:37:35 UTC) #5
Jarin
lgtm. Thanks!
3 years, 10 months ago (2017-02-09 14:20:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682143002/40001
3 years, 10 months ago (2017-02-09 16:08:29 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/193a0c118845d068ab386b5c90d04daaa64e1e86
3 years, 10 months ago (2017-02-09 16:11:01 UTC) #13
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2683203002/ by machenbach@chromium.org. ...
3 years, 10 months ago (2017-02-09 18:05:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682143002/60001
3 years, 10 months ago (2017-02-10 08:48:20 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 09:15:13 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b8c7870c1e803612bdcacaea3359627e523...

Powered by Google App Engine
This is Rietveld 408576698