Prevent icf/comdat folding for OOM_CRASH() entry points.

Prevent icf/comdat folding for OOM_CRASH() entry points.

We have various OOM-failure entry points which call OOM_CRASH() but
not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient
to prevent the linker from common'ing up these identical functions
(see associated bug for an example), leading to confused crash stacks.

Avoid invasive linker optimization by adopting r306650 to OOM_CRASH().

R=haraken,primiano
BUG=690447
Review-Url: https://codereview.chromium.org/2683033008
Cr-Commit-Position: refs/heads/master@{#449582}
Committed: https://chromium.googlesource.com/chromium/src/+/f2724768b6463520d15a68cffd883ae5962c7359

[sof, 2017-02-10 08:28:28]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 08:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-10 08:30:25]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, palmer@chromium.org, primiano@chromium.org

[sof, 2017-02-10 08:30:25]

please take a look.

( OOM_CRASH() is used by partition_allocator/ and within Blink only atm )

[haraken, 2017-02-10 09:19:44]

On 2017/02/10 08:30:25, sof wrote:
> please take a look.
> 
> ( OOM_CRASH() is used by partition_allocator/ and within Blink only atm )

LGTM

[sof, 2017-02-10 09:32:47]

On 2017/02/10 09:19:44, haraken wrote:
> On 2017/02/10 08:30:25, sof wrote:
> > please take a look.
> > 
> > ( OOM_CRASH() is used by partition_allocator/ and within Blink only atm )
> 
> LGTM

thanks, primiano@ for owner review? tia

[commit-bot: I haz the power, 2017-02-10 09:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 09:49:08]

Dry run: This issue passed the CQ dry run.

[Primiano Tucci (use gerrit), 2017-02-10 10:25:42]

lgtm

[sof, 2017-02-10 10:34:23]

Description was changed from

==========
Prevent icf/comdat folding for OOM_CRASH() entry points.

We have various OOM-failure entry points which call OOM_CRASH() but
not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient
to prevent the linker from common'ing up these identical functions
(see associated bug for an example), leading to confused crash stacks.

Avoid invasive linker optimization by adopting r306650 to OOM_CRASH().

R=
BUG=690447
==========

to

==========
Prevent icf/comdat folding for OOM_CRASH() entry points.

We have various OOM-failure entry points which call OOM_CRASH() but
not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient
to prevent the linker from common'ing up these identical functions
(see associated bug for an example), leading to confused crash stacks.

Avoid invasive linker optimization by adopting r306650 to OOM_CRASH().

R=haraken,primiano
BUG=690447
==========

[sof, 2017-02-10 10:34:40]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-02-10 10:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:42:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486722880264930, "parent_rev":
"71a20112eb081b3c5ade56c4d69faa2db433b36d", "commit_rev":
"f2724768b6463520d15a68cffd883ae5962c7359"}

[commit-bot: I haz the power, 2017-02-10 10:43:11]

Description was changed from

==========
Prevent icf/comdat folding for OOM_CRASH() entry points.

We have various OOM-failure entry points which call OOM_CRASH() but
not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient
to prevent the linker from common'ing up these identical functions
(see associated bug for an example), leading to confused crash stacks.

Avoid invasive linker optimization by adopting r306650 to OOM_CRASH().

R=haraken,primiano
BUG=690447
==========

to

==========
Prevent icf/comdat folding for OOM_CRASH() entry points.

We have various OOM-failure entry points which call OOM_CRASH() but
not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient
to prevent the linker from common'ing up these identical functions
(see associated bug for an example), leading to confused crash stacks.

Avoid invasive linker optimization by adopting r306650 to OOM_CRASH().

R=haraken,primiano
BUG=690447

Review-Url: https://codereview.chromium.org/2683033008
Cr-Commit-Position: refs/heads/master@{#449582}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2724768b6463520d15a68cffd88...
==========

[commit-bot: I haz the power, 2017-02-10 10:43:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2724768b6463520d15a68cffd88...