Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2683033008: Prevent icf/comdat folding for OOM_CRASH() entry points. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent icf/comdat folding for OOM_CRASH() entry points. We have various OOM-failure entry points which call OOM_CRASH() but not much more. These are all NO/NEVER_INLINEd, but that isn't sufficient to prevent the linker from common'ing up these identical functions (see associated bug for an example), leading to confused crash stacks. Avoid invasive linker optimization by adopting r306650 to OOM_CRASH(). R=haraken,primiano BUG=690447 Review-Url: https://codereview.chromium.org/2683033008 Cr-Commit-Position: refs/heads/master@{#449582} Committed: https://chromium.googlesource.com/chromium/src/+/f2724768b6463520d15a68cffd883ae5962c7359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M base/allocator/oom.h View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
sof
please take a look. ( OOM_CRASH() is used by partition_allocator/ and within Blink only atm ...
3 years, 10 months ago (2017-02-10 08:30:25 UTC) #4
haraken
On 2017/02/10 08:30:25, sof wrote: > please take a look. > > ( OOM_CRASH() is ...
3 years, 10 months ago (2017-02-10 09:19:44 UTC) #5
sof
On 2017/02/10 09:19:44, haraken wrote: > On 2017/02/10 08:30:25, sof wrote: > > please take ...
3 years, 10 months ago (2017-02-10 09:32:47 UTC) #6
Primiano Tucci (use gerrit)
lgtm
3 years, 10 months ago (2017-02-10 10:25:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683033008/1
3 years, 10 months ago (2017-02-10 10:34:53 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 10:43:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2724768b6463520d15a68cffd88...

Powered by Google App Engine
This is Rietveld 408576698