Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: base/allocator/oom.h

Issue 2683033008: Prevent icf/comdat folding for OOM_CRASH() entry points. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_ALLOCATOR_OOM_H 5 #ifndef BASE_ALLOCATOR_OOM_H
6 #define BASE_ALLOCATOR_OOM_H 6 #define BASE_ALLOCATOR_OOM_H
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
11 #include <windows.h> 11 #include <windows.h>
12 #endif 12 #endif
13 13
14 // Do not want trivial entry points just calling OOM_CRASH() to be
15 // commoned up by linker icf/comdat folding.
16 #define OOM_CRASH_PREVENT_ICF() \
17 volatile int oom_crash_inhibit_icf = __LINE__; \
18 ALLOW_UNUSED_LOCAL(oom_crash_inhibit_icf)
19
14 // OOM_CRASH() - Specialization of IMMEDIATE_CRASH which will raise a custom 20 // OOM_CRASH() - Specialization of IMMEDIATE_CRASH which will raise a custom
15 // exception on Windows to signal this is OOM and not a normal assert. 21 // exception on Windows to signal this is OOM and not a normal assert.
16 #if defined(OS_WIN) 22 #if defined(OS_WIN)
17 #define OOM_CRASH() \ 23 #define OOM_CRASH() \
18 do { \ 24 do { \
25 OOM_CRASH_PREVENT_ICF(); \
19 ::RaiseException(0xE0000008, EXCEPTION_NONCONTINUABLE, 0, nullptr); \ 26 ::RaiseException(0xE0000008, EXCEPTION_NONCONTINUABLE, 0, nullptr); \
20 IMMEDIATE_CRASH(); \ 27 IMMEDIATE_CRASH(); \
21 } while (0) 28 } while (0)
22 #else 29 #else
23 #define OOM_CRASH() IMMEDIATE_CRASH() 30 #define OOM_CRASH() \
31 do { \
32 OOM_CRASH_PREVENT_ICF(); \
33 IMMEDIATE_CRASH(); \
34 } while (0)
24 #endif 35 #endif
25 36
26 #endif // BASE_ALLOCATOR_OOM_H 37 #endif // BASE_ALLOCATOR_OOM_H
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698