Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2683013002: Reland of Android: Use linker script to hide all non-JNI symbols (Closed)

Created:
3 years, 10 months ago by gab
Modified:
3 years, 10 months ago
Reviewers:
digit1, engedy, agrieve, Torne, brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org, ynovikov, Jamie Madill, wolenetz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Use linker script to hide all non-JNI symbols (patchset #1 id:1 of https://codereview.chromium.org/2685933002/ ) Reason for revert: Revert fixed WebKit Android (Nexus4) but... I also reverted https://codereview.chromium.org/2680943003 in parallel as EST sheriff... so now we don't know which one fixed it... tentatively relanding this one to see..! Original issue's description: > Revert of Android: Use linker script to hide all non-JNI symbols (patchset #4 id:60001 of https://codereview.chromium.org/2633593004/ ) > > Reason for revert: > Speculative revert, potential culprit for webkit_tests crashing on "WebKit Android (Nexus4)". > > Stack traces show not much else than JNI managed->native transitions and syscalls. > > Original issue's description: > > Android: Use linker script to hide all non-JNI symbols > > > > The linker script is applied to all shared_library() targets by default, > > just like the hide_jni one was. > > > > This reduces the size of libchrome.so by 220kb. > > > > BUG=448386 > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > > > Review-Url: https://codereview.chromium.org/2633593004 > > Cr-Commit-Position: refs/heads/master@{#448988} > > Committed: https://chromium.googlesource.com/chromium/src/+/6888d5002b2eabe4fac226f0e5124fbd62bdd215 > > TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=448386 > > Review-Url: https://codereview.chromium.org/2685933002 > Cr-Commit-Position: refs/heads/master@{#449028} > Committed: https://chromium.googlesource.com/chromium/src/+/de69a7c823b439d35e7ee716a1da25e05a871efe TBR=torne@chromium.org,digit@chromium.org,brettw@chromium.org,agrieve@chromium.org,engedy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448386 Review-Url: https://codereview.chromium.org/2683013002 Cr-Commit-Position: refs/heads/master@{#449057} Committed: https://chromium.googlesource.com/chromium/src/+/59e1841b41f8902a0f300eb8cc412a73725013ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -69 lines) Patch
M android_webview/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/test/BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
D build/android/android_no_jni_exports.lst View 1 chunk +0 lines, -17 lines 0 comments Download
A build/android/android_only_explicit_jni_exports.lst View 1 chunk +13 lines, -0 lines 0 comments Download
A build/android/android_only_jni_exports.lst View 1 chunk +13 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 2 chunks +3 lines, -8 lines 0 comments Download
M build/config/android/BUILD.gn View 1 chunk +7 lines, -10 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
D components/cronet/android/only_jni_exports.lst View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/test.gni View 1 chunk +1 line, -1 line 0 comments Download
M third_party/netty-tcnative/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/memconsumer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
gab
Created Reland of Android: Use linker script to hide all non-JNI symbols
3 years, 10 months ago (2017-02-08 19:13:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683013002/1
3 years, 10 months ago (2017-02-08 19:14:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683013002/1
3 years, 10 months ago (2017-02-08 19:16:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/59e1841b41f8902a0f300eb8cc412a73725013ed
3 years, 10 months ago (2017-02-08 19:16:17 UTC) #9
Michael Achenbach
Clearly looks broken again, so revert again? https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/60635
3 years, 10 months ago (2017-02-08 21:20:05 UTC) #10
gab
3 years, 10 months ago (2017-02-08 21:22:12 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2684123002/ by gab@chromium.org.

The reason for reverting is: This was the actual culprit, will re-land v8
rolls..

Powered by Google App Engine
This is Rietveld 408576698