Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2680943003: Revert of Update V8 to version 5.8.153. (Closed)

Created:
3 years, 10 months ago by gab
Modified:
3 years, 10 months ago
CC:
chromium-reviews, engedy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.8.153. (patchset #1 id:1 of https://codereview.chromium.org/2682083002/ ) Reason for revert: Roll is suspected for WebKit Android (Nexus4) failures https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/60628 Original issue's description: > Update V8 to version 5.8.153. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/f0034287..899690a5 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2682083002 > Cr-Commit-Position: refs/heads/master@{#448989} > Committed: https://chromium.googlesource.com/chromium/src/+/581fe07fcbe036023c205b39d4ee0ec6f5fe6f54 TBR=hablich@chromium.org,littledan@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2680943003 Cr-Commit-Position: refs/heads/master@{#449029} Committed: https://chromium.googlesource.com/chromium/src/+/fe8d0ed2e37f97f330ac27cffc38d4ae061cdd79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
gab
Created Revert of Update V8 to version 5.8.153.
3 years, 10 months ago (2017-02-08 17:38:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680943003/1
3 years, 10 months ago (2017-02-08 17:45:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fe8d0ed2e37f97f330ac27cffc38d4ae061cdd79
3 years, 10 months ago (2017-02-08 17:47:38 UTC) #6
Michael Achenbach
lgtm
3 years, 10 months ago (2017-02-08 17:56:31 UTC) #7
gab
FYI, revert fixed WebKit Android (Nexus4) but https://codereview.chromium.org/2683013002/ was reverted in parallel by another sheriff ...
3 years, 10 months ago (2017-02-08 19:16:39 UTC) #8
Michael Achenbach
On 2017/02/08 19:16:39, gab wrote: > FYI, revert fixed WebKit Android (Nexus4) but > https://codereview.chromium.org/2683013002/ ...
3 years, 10 months ago (2017-02-08 19:59:06 UTC) #9
Michael Achenbach
On 2017/02/08 19:59:06, Michael Achenbach wrote: > On 2017/02/08 19:16:39, gab wrote: > > FYI, ...
3 years, 10 months ago (2017-02-08 20:18:51 UTC) #10
Michael Achenbach
CC the other sheriff... could you please reland this if there's green light?
3 years, 10 months ago (2017-02-08 20:20:40 UTC) #11
gab
3 years, 10 months ago (2017-02-08 21:22:54 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2682813004/ by gab@chromium.org.

The reason for reverting is: Relanding: not culprit..

Powered by Google App Engine
This is Rietveld 408576698