Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2682863004: [Ash] Remove unused strings from ash/ash_strings.grd (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ash] Remove unused strings from ash/ash_strings.grd BUG=690075 TEST=builds Review-Url: https://codereview.chromium.org/2682863004 Cr-Commit-Position: refs/heads/master@{#449401} Committed: https://chromium.googlesource.com/chromium/src/+/145325203534c94394bcb6966851486b8fcd29e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M ash/ash_strings.grd View 5 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
Hi Scott, PTAL
3 years, 10 months ago (2017-02-09 16:24:28 UTC) #6
sky
LGTM
3 years, 10 months ago (2017-02-09 20:41:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682863004/1
3 years, 10 months ago (2017-02-09 20:42:51 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 20:49:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/145325203534c94394bcb6966851...

Powered by Google App Engine
This is Rietveld 408576698