Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2682733003: Add AIA fetching feature info to certificate reports (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
meacer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add AIA fetching feature info to certificate reports This CL adds a bit to certificate reports to indicate whether the Android AIA fetching feature is enabled. This will be used to pull out examples of certificate error reports where AIA fetching was enabled but didn't help. BUG=688272 Review-Url: https://codereview.chromium.org/2682733003 Cr-Commit-Position: refs/heads/master@{#448763} Committed: https://chromium.googlesource.com/chromium/src/+/40ec5a581b662b9f120e577df28363c3e5991990

Patch Set 1 #

Patch Set 2 : OS-specific includes #

Patch Set 3 : Add UMA statistic for AIA fetches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -2 lines) Patch
M components/certificate_reporting/cert_logger.proto View 1 chunk +15 lines, -0 lines 0 comments Download
M components/certificate_reporting/error_report.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M components/certificate_reporting/error_report_unittest.cc View 1 3 chunks +47 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_android.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
estark
meacer, PTAL?
3 years, 10 months ago (2017-02-07 21:11:04 UTC) #6
meacer
Lgtm. Didn't know that this was already implemented, that's great.
3 years, 10 months ago (2017-02-07 21:18:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2682733003/20001
3 years, 10 months ago (2017-02-07 21:22:20 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 22:56:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40ec5a581b662b9f120e577df283...

Powered by Google App Engine
This is Rietveld 408576698