net/cert/cert_verify_proc_android.cc - Issue 2682733003: Add AIA fetching feature info to certificate reports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_android.cc

Issue 2682733003: Add AIA fetching feature info to certificate reports (Closed)

Patch Set: Add UMA statistic for AIA fetches Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_verify_proc_android.cc

diff --git a/net/cert/cert_verify_proc_android.cc b/net/cert/cert_verify_proc_android.cc

index a59ab284467fdb1936f92aff7d8e421c4ce7de13..e0a442aa78a787ed5326e8a51a2e42ed6f5a4030 100644

--- a/net/cert/cert_verify_proc_android.cc

+++ b/net/cert/cert_verify_proc_android.cc

@@ -106,6 +106,8 @@ bool PerformAIAFetchAndAddResultToVector(scoped_refptr<CertNetFetcher> fetcher,

Error error;

std::vector<uint8_t> aia_fetch_bytes;

request->WaitForResult(&error, &aia_fetch_bytes);

+ UMA_HISTOGRAM_SPARSE_SLOWLY("Net.Certificate.AndroidAIAFetchError",

+ std::abs(error));

if (error != OK)

return false;

CertErrors errors;